-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix missing array clone when building table filter for mv index access path (#52613) #52621
planner: fix missing array clone when building table filter for mv index access path (#52613) #52621
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #52621 +/- ##
================================================
Coverage ? 72.2835%
================================================
Files ? 1467
Lines ? 426880
Branches ? 0
================================================
Hits ? 308564
Misses ? 99018
Partials ? 19298
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, time-and-fate The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #52613
What problem does this PR solve?
Issue Number: close #52609
Problem Summary:
The
slices.Delete()
below will unexpectedly modify the inputallConds
.What changed and how does it work?
Use
slices.Clone()
to make sure a new array is allocated.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.