Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning/importinto: fix insert err after import for AUTO_ID_CACHE=1 and SHARD_ROW_ID_BITS (#52712) #52723

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52712

What problem does this PR solve?

Issue Number: close #52654

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
mysql> CREATE TABLE t (
    ->   id bigint(20) unsigned NOT NULL AUTO_INCREMENT,
    ->   PRIMARY KEY (id) /*T![clustered_index] NONCLUSTERED */
    -> ) /*T![auto_id_cache] AUTO_ID_CACHE=1 */ /*T! SHARD_ROW_ID_BITS=4 PRE_SPLIT_REGIONS=3 */;
Query OK, 0 rows affected (0.09 sec)

mysql>
mysql> import into t from select 1778961125641936898;
Query OK, 1 row affected (0.30 sec)
Records: 1, ID: 0e8a4adb-47df-4790-a237-5a489e25d9c6

mysql> insert into t values ();
Query OK, 1 row affected (0.01 sec)

mysql> select *, _tidb_rowid from t;
+---------------------+---------------------+
| id                  | _tidb_rowid         |
+---------------------+---------------------+
| 1778961125641936898 | 1152921504606846977 |
| 1778961125641936899 | 2882303761517117442 |
+---------------------+---------------------+
2 rows in set (0.01 sec)
mysql> select *, _tidb_rowid & x'07FFFFFFFFFFFFFF' from t;
+---------------------+-----------------------------------+
| id                  | _tidb_rowid & x'07FFFFFFFFFFFFFF' |
+---------------------+-----------------------------------+
| 1778961125641936899 |                                 2 |
| 1778961125641936898 |                                 1 |
+---------------------+-----------------------------------+
2 rows in set (0.01 sec)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 18, 2024
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. label Apr 18, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 18, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 18, 2024
@wuhuizuo
Copy link
Contributor

@D3Hunter it has soft merge conflicts.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 21, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 21, 2024
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 21, 2024
Copy link

ti-chi-bot bot commented May 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-21 02:48:53.02361931 +0000 UTC m=+2139886.780754868: ☑️ agreed by D3Hunter.
  • 2024-05-21 02:52:03.702382136 +0000 UTC m=+2140077.459517709: ☑️ agreed by Benjamin2037.

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 15 lines in your changes are missing coverage. Please review.

Please upload report for BASE (release-7.5@3a7cd61). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #52723   +/-   ##
================================================
  Coverage               ?   72.2217%           
================================================
  Files                  ?       1411           
  Lines                  ?     411657           
  Branches               ?          0           
================================================
  Hits                   ?     297306           
  Misses                 ?      94569           
  Partials               ?      19782           
Flag Coverage Δ
unit 72.2217% <57.1428%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 54.2349% <0.0000%> (?)

Copy link

ti-chi-bot bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, Benjamin2037, D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 21, 2024
@ti-chi-bot ti-chi-bot bot merged commit 3b4de20 into pingcap:release-7.5 May 21, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants