ddl: Better error when check constraint is off

[dveeden]

What problem does this PR solve?

Issue Number: close #52815

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dveeden]

Without this PR:

mysql> CREATE TABLE t1 (id INT PRIMARY KEY, CHECK (id<10));
Query OK, 0 rows affected, 1 warning (0.01 sec)

mysql> SHOW WARNINGS;
+---------+------+---------------------------------------+
| Level   | Code | Message                               |
+---------+------+---------------------------------------+
| Warning | 1105 | the switch of check constraint is off |
+---------+------+---------------------------------------+
1 row in set (0.00 sec)

With this PR:

mysql> CREATE TABLE t2 (id INT PRIMARY KEY, CHECK (id<10));
Query OK, 0 rows affected, 1 warning (0.01 sec)

mysql> SHOW WARNINGS;
+---------+------+-------------------------------------+
| Level   | Code | Message                             |
+---------+------+-------------------------------------+
| Warning | 1105 | tidb_enable_check_constraint is off |
+---------+------+-------------------------------------+
1 row in set (0.00 sec)

This makes it easier for the user to find out what variable they might have to change and lookup the right docs etc.

[dveeden]

/ok-to-test

[Defined2014]

/retest

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 74.3141%. Comparing base (f0af776) to head (4821014).
Report is 2 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #52814        +/-   ##
================================================
- Coverage   74.3523%   74.3141%   -0.0383%     
================================================
  Files          1494       1513        +19     
  Lines        356302     447013     +90711     
================================================
+ Hits         264919     332194     +67275     
- Misses        72035      94418     +22383     
- Partials      19348      20401      +1053     

Flag	Coverage Δ
integration	49.1668% <40.0000%> (?)
unit	71.2646% <0.0000%> (-1.8416%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (-2.3014%)	⬇️
parser	∅ <ø> (∅)
br	46.7395% <ø> (+3.7726%)	⬆️

[dveeden]

/retest

[dveeden]

/retest

[dveeden]

@zimulala @fzzf678 PTAL

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-04-23 01:19:01.951873965 +0000 UTC m=+50298.691776877: ☑️ agreed by Defined2014.
• 2024-05-06 08:48:39.135978312 +0000 UTC m=+865472.893113885: ☑️ agreed by fzzf678.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, fzzf678, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Defined2014,zimulala]
• pkg/ddl/OWNERS [zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment