Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support add column with default value expression (#52677) #52829

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52677

What problem does this PR solve?

Issue Number: close #52676

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Apr 23, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 23, 2024
Copy link

ti-chi-bot bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 23, 2024
Copy link

ti-chi-bot bot commented Apr 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-23 04:10:12.348061778 +0000 UTC m=+60569.087964690: ☑️ agreed by Defined2014.
  • 2024-04-23 05:10:44.229347864 +0000 UTC m=+64200.969250775: ☑️ agreed by wjhuang2016.

@zimulala
Copy link
Contributor

/test unit-test

Copy link

tiprow bot commented Apr 23, 2024

@zimulala: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 23, 2024
@zimulala
Copy link
Contributor

/test unit-test

Copy link

ti-chi-bot bot commented Apr 23, 2024

@zimulala: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test pull-br-integration-test
  • /test pull-lightning-integration-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/release-8.1/ghpr_build
  • pingcap/tidb/release-8.1/ghpr_check
  • pingcap/tidb/release-8.1/ghpr_check2
  • pingcap/tidb/release-8.1/ghpr_mysql_test
  • pingcap/tidb/release-8.1/ghpr_unit_test

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Apr 23, 2024

@zimulala: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zimulala
Copy link
Contributor

/retest-required

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-8.1@cfeca9b). Click here to learn what that means.
The diff coverage is 50.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #52829   +/-   ##
================================================
  Coverage               ?   72.2877%           
================================================
  Files                  ?       1468           
  Lines                  ?     427226           
  Branches               ?          0           
================================================
  Hits                   ?     308832           
  Misses                 ?      99088           
  Partials               ?      19306           
Flag Coverage Δ
unit 71.1497% <50.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.0929% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit 85ae939 into pingcap:release-8.1 Apr 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants