Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl,mdl: fix the issue that the table_ids overlap regex is not correct #52879

Merged
merged 1 commit into from
May 11, 2024

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Apr 25, 2024

What problem does this PR solve?

Issue Number: close #52758

Problem Summary:

The regexp in mdl_view is not correct:

SELECT ',10,` regexp ',1|2,'

This SQL will return 1, because it actually matches ',1' or '2,'.

What changed and how does it work?

This PR modified the REGEXP from ,1|2, to ,(1|2),.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Apr 25, 2024
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 75.9994%. Comparing base (788d505) to head (5eace9c).
Report is 25 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52879        +/-   ##
================================================
+ Coverage   74.4098%   75.9994%   +1.5896%     
================================================
  Files          1490       1492         +2     
  Lines        356051     436224     +80173     
================================================
+ Hits         264937     331528     +66591     
- Misses        71835      84404     +12569     
- Partials      19279      20292      +1013     
Flag Coverage Δ
integration 51.5805% <16.6666%> (?)
unit 71.9555% <50.0000%> (-1.2169%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 61.1965% <ø> (+18.3080%) ⬆️

@YangKeao YangKeao force-pushed the fix-52758 branch 2 times, most recently from ce0f224 to 7f267f1 Compare April 25, 2024 07:00
@YangKeao YangKeao requested a review from wjhuang2016 April 25, 2024 07:04
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 25, 2024
@YangKeao YangKeao requested a review from YuJuncen April 25, 2024 07:42
@YangKeao
Copy link
Member Author

/retest

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 25, 2024
Copy link

ti-chi-bot bot commented Apr 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-25 07:39:27.18813874 +0000 UTC m=+245923.928041652: ☑️ agreed by wjhuang2016.
  • 2024-04-25 11:42:55.129744248 +0000 UTC m=+260531.869647160: ☑️ agreed by zimulala.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2024
Copy link

ti-chi-bot bot commented Apr 26, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@easonn7
Copy link

easonn7 commented May 8, 2024

/approve

Copy link

ti-chi-bot bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, wjhuang2016, YuJuncen, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 8, 2024
@Defined2014 Defined2014 removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2024
@Defined2014
Copy link
Contributor

/retest

2 similar comments
@YangKeao
Copy link
Member Author

/retest

@YangKeao
Copy link
Member Author

/retest

@Defined2014
Copy link
Contributor

/retest

1 similar comment
@Defined2014
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit af825ac into pingcap:master May 11, 2024
27 of 28 checks passed
@Defined2014 Defined2014 added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels May 11, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #53190.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #53191.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 11, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #53192.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 11, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 11, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #53193.

@YangKeao YangKeao removed needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REGEXP together with CONCAT(..REPLACE..) might return unexpected result
7 participants