Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix the slow test TestIntersectionWithDifferentConcurrency #52976

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 29, 2024

What problem does this PR solve?

Issue Number: close #47326

Problem Summary: planner: fix the slow test TestIntersectionWithDifferentConcurrency

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Apr 29, 2024
Copy link

tiprow bot commented Apr 29, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 29, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 29, 2024
Copy link

ti-chi-bot bot commented Apr 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-29 07:54:02.967529999 +0000 UTC m=+257396.724665572: ☑️ agreed by time-and-fate.
  • 2024-04-29 08:03:55.62168277 +0000 UTC m=+257989.378818342: ☑️ agreed by AilinKid.

Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, elsa0520, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,elsa0520,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.7286%. Comparing base (5333ac3) to head (3892df2).

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #52976         +/-   ##
=================================================
- Coverage   72.3746%   55.7286%   -16.6460%     
=================================================
  Files          1482       1595        +113     
  Lines        428762     598421     +169659     
=================================================
+ Hits         310315     333492      +23177     
- Misses        99149     241882     +142733     
- Partials      19298      23047       +3749     
Flag Coverage Δ
integration 37.0268% <ø> (?)
unit 71.2121% <ø> (+0.0019%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.0184% <ø> (+8.8403%) ⬆️

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 29, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 26e3b5f into pingcap:master Apr 29, 2024
21 of 23 checks passed
Copy link

tiprow bot commented Apr 29, 2024

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990 qw4990 added the affects-7.5 This bug affects the 7.5.x(LTS) versions. label May 21, 2024
@qw4990
Copy link
Contributor Author

qw4990 commented May 21, 2024

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

@qw4990: new pull request created to branch release-7.5: #53453.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #55035.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. approved lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

timeout of TestIntersectionWithDifferentConcurrency
5 participants