-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: add more options for br sql client #53039
Conversation
Skipping CI for Draft Pull Request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53039 +/- ##
================================================
+ Coverage 72.4916% 75.4939% +3.0022%
================================================
Files 1506 1507 +1
Lines 430600 434721 +4121
================================================
+ Hits 312149 328188 +16039
+ Misses 99229 86118 -13111
- Partials 19222 20415 +1193
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test unit-test |
@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test check-dev2 |
@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
Co-authored-by: 山岚 <[email protected]>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, easonn7, Leavrth, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: close #53040
Problem Summary:
What changed and how does it work?
We added the following options for br sql client:
the general options are:
ENCRYPTION_METHOD
for Encrypt/decrypt method, be one of plaintext|aes128-ctr|aes192-ctr|aes256-ctr case-insensitively, "plaintext" represents no encrypt/decrypt (default "plaintext")ENCRYPTION_KEYFILE
for FilePath, its content is used as the cipher-keyCHECKSUM_CONCURRENCY
for The concurrency of checksumming in one table (default 4)the options for backup are :
IGNORE_STATS
for wether ignore backup stats (default true)COMPRESSION_LEVEL
for compression level used for sst file compressionCOMPRESSION_TYPE
for backup sst file compression algorithm, value can be one of 'lz4|zstd|snappy' (default "zstd")the options for restore are:
WAIT_TIFLASH_READY
for whether wait tiflash replica ready if tiflash existsWITH_SYS_TABLE
for whether restore system privilege tables on default setting (default true)LOAD_STATS
for whether run load stats at end of snapshot restore task (default true)Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.