-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: PropagateType
should never let orignal data overflow
#53045
expression: PropagateType
should never let orignal data overflow
#53045
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #53045 +/- ##
================================================
+ Coverage 72.0214% 74.0513% +2.0298%
================================================
Files 1508 1510 +2
Lines 434823 439603 +4780
================================================
+ Hits 313166 325532 +12366
+ Misses 102084 93837 -8247
- Partials 19573 20234 +661
Flags with carried forward coverage won't be shown. Click here to find out more.
|
4c3573d
to
3fb2172
Compare
PropagateType
should never let orignal data overflow
Signed-off-by: xufei <[email protected]>
Signed-off-by: xufei <[email protected]>
Signed-off-by: xufei <[email protected]>
Signed-off-by: xufei <[email protected]>
Signed-off-by: xufei <[email protected]>
5a0b18a
to
e68079c
Compare
Signed-off-by: xufei <[email protected]>
/test unit-test |
@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test check-dev |
@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guo-shaoge, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
@windtalker: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Co-authored-by: guo-shaoge <[email protected]>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #52672
Problem Summary:
What changed and how does it work?
When propagate type in
tidb/pkg/expression/expression.go
Line 1192 in b6435d1
make sure that the original data is never be overflow under new type.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.