executor: disable probe short path in hash join

[windtalker]

What problem does this PR solve?

Issue Number: close #51998

Problem Summary:
In TiDB's hash join, there is a short path in probe side:

tidb/pkg/executor/join/join.go

Lines 275 to 277 in 65817ac

	if probeSideResult.NumRows() == 0 && !fetcher.UseOuterToBuild {
	fetcher.finished.Store(true)
	}

If the probe side is empty, and current join use inner side to build, then the join can mark to finished without waiting the build side. This short-path can cause random fail for the case that probe side is empty, but build side may meet error during execution. In this case, there is a data race between build side and probe side:

• if probe side is detected to be empty before build side meet error, the hash join will return empty result without throwing error
• if probe side is detected to be empty after build side meet error, then hash join will throw error

This will cause random fail

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.7272%. Comparing base (87247c1) to head (8183d72).
Report is 4 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #53079        +/-   ##
================================================
+ Coverage   72.4348%   74.7272%   +2.2923%     
================================================
  Files          1492       1514        +22     
  Lines        428995     438504      +9509     
================================================
+ Hits         310742     327682     +16940     
+ Misses        98991      90324      -8667     
- Partials      19262      20498      +1236     

Flag	Coverage Δ
integration	50.9968% <0.0000%> (?)
unit	71.4007% <100.0000%> (+0.0762%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (ø)
parser	∅ <ø> (∅)
br	50.4952% <ø> (+9.0516%)	⬆️

mysql has different behavior

[ti-chi-bot]

@XuHuaiyu: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yibin87]

LGTM

[ti-chi-bot]

@yibin87: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[windtalker]

/test check-dev2

[tiprow]

@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, XuHuaiyu, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [XuHuaiyu,guo-shaoge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-05-09 07:16:04.313300222 +0000 UTC m=+1119118.070435795: ☑️ agreed by XuHuaiyu.
• 2024-05-10 03:19:42.908991361 +0000 UTC m=+1191336.666126934: ☑️ agreed by guo-shaoge.

[windtalker]

/test check-dev2

[tiprow]

@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[windtalker]

/test check-dev2

[tiprow]

@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[windtalker]

/test check-dev2

[windtalker]

/test check-dev2

[tiprow]

@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[windtalker]

/test check-dev2

[tiprow]

@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[windtalker]

/test check-dev2

[tiprow]

@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[windtalker]

/test check-dev2

[tiprow]

@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[windtalker]

/test check-dev2

[tiprow]

@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[windtalker]

/test check-dev2

[tiprow]

@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[windtalker]

/test pull-integration-ddl-test

[windtalker]

/test unit-test

[tiprow]

@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-integration-ddl-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiprow]

@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[windtalker]

/test check-dev2

[tiprow]

@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[windtalker]

/test check-dev2

[tiprow]

@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.1: #53183.