Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix the primary key in index is not in restored format (#53118) #53132

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #53118

What problem does this PR solve?

Issue Number: close #52510

Problem Summary:
when fast reorg and new collation are enabled, index backfilling only considers the need to restore the index columns, but ignores the primary key columns. The result is that the primary key in the index is not restored.

What changed and how does it work?

When considering the need to restore an index, check both the index columns and the primary key columns.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

- Fix the collation of the primary key in secondary indexes is wrong when tidb_ddl_enable_fast_reorg is enabled

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels May 9, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 9, 2024
@djshow832 djshow832 requested review from wjhuang2016 and tangenta May 9, 2024 07:21
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-8.1@64ca76e). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #53132   +/-   ##
================================================
  Coverage               ?   71.2073%           
================================================
  Files                  ?       1463           
  Lines                  ?     421048           
  Branches               ?          0           
================================================
  Hits                   ?     299817           
  Misses                 ?     100781           
  Partials               ?      20450           
Flag Coverage Δ
unit 71.2073% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 40.9887% <0.0000%> (?)

@djshow832
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 9, 2024
Copy link

ti-chi-bot bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 10, 2024
Copy link

ti-chi-bot bot commented May 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-09 08:39:27.971396437 +0000 UTC m=+1124121.728532010: ☑️ agreed by tangenta.
  • 2024-05-10 02:38:08.802662612 +0000 UTC m=+1188842.559798182: ☑️ agreed by YangKeao.

@ti-chi-bot ti-chi-bot bot merged commit 08b80ed into pingcap:release-8.1 May 10, 2024
18 checks passed
@wuhuizuo wuhuizuo deleted the cherry-pick-53118-to-release-8.1 branch May 11, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants