-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix the primary key in index is not in restored format (#53118) #53132
ddl: fix the primary key in index is not in restored format (#53118) #53132
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #53132 +/- ##
================================================
Coverage ? 71.2073%
================================================
Files ? 1463
Lines ? 421048
Branches ? 0
================================================
Hits ? 299817
Misses ? 100781
Partials ? 20450
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #53118
What problem does this PR solve?
Issue Number: close #52510
Problem Summary:
when fast reorg and new collation are enabled, index backfilling only considers the need to restore the index columns, but ignores the primary key columns. The result is that the primary key in the index is not restored.
What changed and how does it work?
When considering the need to restore an index, check both the index columns and the primary key columns.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.