Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: fix flashback integration test to make it more stable #53179

Merged
merged 1 commit into from
May 11, 2024

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented May 10, 2024

What problem does this PR solve?

Issue Number: close #53158

Problem Summary:

What changed and how does it work?

Retry on this kind of error:

region 40 is in flashback progress, FlashbackStartTS is 449658828228919302

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 10, 2024
@tiancaiamao tiancaiamao requested a review from Defined2014 May 10, 2024 12:59
Copy link

tiprow bot commented May 10, 2024

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tiancaiamao tiancaiamao requested review from GMHDBJD and ywqzzy May 10, 2024 12:59
Copy link
Contributor

@Defined2014 Defined2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, first let ci work properly.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.7967%. Comparing base (f304f04) to head (ca0fcdf).
Report is 16 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53179        +/-   ##
================================================
+ Coverage   72.4716%   74.7967%   +2.3251%     
================================================
  Files          1491       1492         +1     
  Lines        429012     433690      +4678     
================================================
+ Hits         310912     324386     +13474     
+ Misses        98878      89378      -9500     
- Partials      19222      19926       +704     
Flag Coverage Δ
integration 49.2339% <100.0000%> (?)
unit 71.3505% <0.0000%> (-0.0136%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.1740% <ø> (+8.7304%) ⬆️

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 10, 2024
Copy link

ti-chi-bot bot commented May 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-10 13:03:08.662403841 +0000 UTC m=+1226342.419539415: ☑️ agreed by Defined2014.
  • 2024-05-10 14:18:59.604583015 +0000 UTC m=+1230893.361718589: ☑️ agreed by hawkingrei.

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented May 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, GMHDBJD, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 11, 2024
@ti-chi-bot ti-chi-bot bot merged commit 1bac22a into pingcap:master May 11, 2024
22 of 23 checks passed
@tiancaiamao tiancaiamao deleted the ci-stable branch May 11, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test in the flashback_test
4 participants