-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix the issue that UnionAll didn't handle the range bump case (#52542) #53211
planner: fix the issue that UnionAll didn't handle the range bump case (#52542) #53211
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Yang Keao <[email protected]>
…52542-to-release-7.5 Signed-off-by: Yang Keao <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #53211 +/- ##
================================================
Coverage ? 72.3265%
================================================
Files ? 1411
Lines ? 412594
Branches ? 0
================================================
Hits ? 298415
Misses ? 94264
Partials ? 19915
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #52542
What problem does this PR solve?
Issue Number: close #52472
Problem Summary:
The
UnionAll
should usetypes.AggFieldType
to aggregate the fieldTypes. This function will handle the bump of range. For example, the aggregate of signed and unsigned long will give signed long long.What changed and how does it work?
Use
types.AggFieldType
instead oftypes.MergeFieldType
.This PR also makes
types.MergeFieldType
private, as it's easy to make such mistakes.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.