Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: clarify the cast(... as char array) error message | tidb-test=pr/2326 #53220

Merged
merged 1 commit into from
May 13, 2024

Conversation

YangKeao
Copy link
Member

What problem does this PR solve?

Issue Number: close #53219

Problem Summary:

The error message was misleading. TiDB actually supports casting to char(16) array. The user needs to add length after facing this error.

What changed and how does it work?

Change the error message to tell the user that the problem is the missed length.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.7175%. Comparing base (601e21c) to head (f829768).
Report is 7 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53220        +/-   ##
================================================
+ Coverage   72.4105%   74.7175%   +2.3070%     
================================================
  Files          1492       1493         +1     
  Lines        429312     431928      +2616     
================================================
+ Hits         310867     322726     +11859     
+ Misses        99145      89327      -9818     
- Partials      19300      19875       +575     
Flag Coverage Δ
integration 49.2674% <100.0000%> (?)
unit 71.2853% <0.0000%> (-0.0137%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.2308% <ø> (+8.8006%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 13, 2024
@YangKeao YangKeao changed the title expression: clarify the cast(... as char array) error message expression: clarify the cast(... as char array) error message | tidb-test=pr/2326 May 13, 2024
@YangKeao YangKeao requested a review from zanmato1984 May 13, 2024 11:12
@YangKeao
Copy link
Member Author

/retest

Copy link

ti-chi-bot bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dveeden, zanmato1984

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 13, 2024
Copy link

ti-chi-bot bot commented May 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-13 11:07:56.526336812 +0000 UTC m=+1478630.283472385: ☑️ agreed by dveeden.
  • 2024-05-13 11:45:40.052324996 +0000 UTC m=+1480893.809460561: ☑️ agreed by zanmato1984.

@dveeden
Copy link
Contributor

dveeden commented May 13, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 37b29bd into pingcap:master May 13, 2024
23 checks passed
terry1purcell pushed a commit to terry1purcell/tidb that referenced this pull request May 17, 2024
RidRisR pushed a commit to RidRisR/tidb that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The error message of cast(xxx as char array) is a little misleading
3 participants