-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: clarify the cast(... as char array)
error message | tidb-test=pr/2326
#53220
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #53220 +/- ##
================================================
+ Coverage 72.4105% 74.7175% +2.3070%
================================================
Files 1492 1493 +1
Lines 429312 431928 +2616
================================================
+ Hits 310867 322726 +11859
+ Misses 99145 89327 -9818
- Partials 19300 19875 +575
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Yang Keao <[email protected]>
cast(... as char array)
error messagecast(... as char array)
error message | tidb-test=pr/2326
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dveeden, zanmato1984 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
What problem does this PR solve?
Issue Number: close #53219
Problem Summary:
The error message was misleading. TiDB actually supports casting to
char(16) array
. The user needs to add length after facing this error.What changed and how does it work?
Change the error message to tell the user that the problem is the missed length.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.