Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: fix unstable test for conflict detection #53225

Merged
merged 2 commits into from
May 14, 2024

Conversation

lyzx2001
Copy link
Contributor

@lyzx2001 lyzx2001 commented May 13, 2024

What problem does this PR solve?

Issue Number: ref #52306

Problem Summary:

What changed and how does it work?

Fix unstable test for lightning_duplicate_resolution_merge.
https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Fpull_lightning_integration_test/detail/pull_lightning_integration_test/691/pipeline/

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 13, 2024
Copy link

tiprow bot commented May 13, 2024

Hi @lyzx2001. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lyzx2001
Copy link
Contributor Author

/test pull-lightning-integration-test

Copy link

tiprow bot commented May 13, 2024

@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.6600%. Comparing base (fa94f49) to head (b5244ac).
Report is 12 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53225        +/-   ##
================================================
+ Coverage   72.4109%   74.6600%   +2.2490%     
================================================
  Files          1493       1515        +22     
  Lines        429341     439488     +10147     
================================================
+ Hits         310890     328122     +17232     
+ Misses        99162      90804      -8358     
- Partials      19289      20562      +1273     
Flag Coverage Δ
integration 50.6896% <ø> (?)
unit 71.2539% <ø> (-0.0490%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.2074% <ø> (+8.7705%) ⬆️

@lyzx2001
Copy link
Contributor Author

/cc @lance6716

@ti-chi-bot ti-chi-bot bot requested a review from lance6716 May 13, 2024 08:24
@lance6716
Copy link
Contributor

lance6716 commented May 13, 2024

please find the root cause rather than remove the test. There should be 10 records of PK 1,2,3,4,5,6,13,14,15,16.

@lyzx2001
Copy link
Contributor Author

/test pull-lightning-integration-test

Copy link

tiprow bot commented May 13, 2024

@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lyzx2001
Copy link
Contributor Author

please find the root cause rather than remove the test. There should be 10 records of PK 1,2,3,4,5,6,13,14,15,16.

In log we can see that lightning 2 exited at 16:21:41.696, but lightning 1 met error "Table "lightning_metadata.task_meta_v2' doesn't exist" at 16:21:41.702, where we may infer lightning 2 deleted the table too soon. So the solution can be manually adding sleep time to extend the import time.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 13, 2024
@lyzx2001
Copy link
Contributor Author

/cc @D3Hunter

@ti-chi-bot ti-chi-bot bot requested a review from D3Hunter May 13, 2024 13:56
Copy link

ti-chi-bot bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 14, 2024
Copy link

ti-chi-bot bot commented May 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-13 13:25:10.683945482 +0000 UTC m=+1486864.441081056: ☑️ agreed by lance6716.
  • 2024-05-14 08:11:52.940787383 +0000 UTC m=+1554466.697922956: ☑️ agreed by D3Hunter.

@ti-chi-bot ti-chi-bot bot merged commit 46d842f into pingcap:master May 14, 2024
24 checks passed
terry1purcell pushed a commit to terry1purcell/tidb that referenced this pull request May 17, 2024
RidRisR pushed a commit to RidRisR/tidb that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants