-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: fix unstable test for conflict detection #53225
lightning: fix unstable test for conflict detection #53225
Conversation
Hi @lyzx2001. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-lightning-integration-test |
@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #53225 +/- ##
================================================
+ Coverage 72.4109% 74.6600% +2.2490%
================================================
Files 1493 1515 +22
Lines 429341 439488 +10147
================================================
+ Hits 310890 328122 +17232
+ Misses 99162 90804 -8358
- Partials 19289 20562 +1273
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/cc @lance6716 |
please find the root cause rather than remove the test. There should be 10 records of PK 1,2,3,4,5,6,13,14,15,16. |
/test pull-lightning-integration-test |
@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
In log we can see that lightning 2 exited at 16:21:41.696, but lightning 1 met error "Table "lightning_metadata.task_meta_v2' doesn't exist" at 16:21:41.702, where we may infer lightning 2 deleted the table too soon. So the solution can be manually adding sleep time to extend the import time. |
/cc @D3Hunter |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #52306
Problem Summary:
What changed and how does it work?
Fix unstable test for lightning_duplicate_resolution_merge.
https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Fpull_lightning_integration_test/detail/pull_lightning_integration_test/691/pipeline/
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.