Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix a bug about setting MaxIndexLength #53284

Merged
merged 1 commit into from
May 15, 2024

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented May 15, 2024

What problem does this PR solve?

Issue Number: close #53281

Problem Summary:
Both scenarios are explained in the issue.

Introduce code for this issue: https://github.com/pingcap/tidb/pull/50624/files#diff-45ad039a8b87835b475a52615355c444538d3a1f31a84d7b3ac94e15b1ce8721R126-R127

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 15, 2024
Copy link

tiprow bot commented May 15, 2024

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.9529%. Comparing base (6aef624) to head (8b1dce0).
Report is 7 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53284        +/-   ##
================================================
+ Coverage   72.4435%   74.9529%   +2.5093%     
================================================
  Files          1493       1497         +4     
  Lines        429362     432661      +3299     
================================================
+ Hits         311045     324292     +13247     
+ Misses        99037      88435     -10602     
- Partials      19280      19934       +654     
Flag Coverage Δ
integration 49.8580% <100.0000%> (?)
unit 71.7219% <100.0000%> (+0.3875%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.4818% <ø> (+9.0483%) ⬆️

Copy link

ti-chi-bot bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 15, 2024
Copy link

ti-chi-bot bot commented May 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-15 04:26:21.364238863 +0000 UTC m=+1627335.121374435: ☑️ agreed by Defined2014.
  • 2024-05-15 06:08:18.337950202 +0000 UTC m=+1633452.095085776: ☑️ agreed by tangenta.

@zimulala
Copy link
Contributor Author

/retest-required

Copy link

tiprow bot commented May 15, 2024

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 59c7da1 into pingcap:master May 15, 2024
23 checks passed
@zimulala zimulala deleted the zimuxia/max-idx-len branch May 15, 2024 11:07
terry1purcell pushed a commit to terry1purcell/tidb that referenced this pull request May 17, 2024
@bb7133 bb7133 added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels May 20, 2024
@bb7133
Copy link
Member

bb7133 commented May 20, 2024

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #53408.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 20, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #53409.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding an index failed with DXF enabled and max-index-length set in one TiDB node.
5 participants