Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: speed up integration test #53426

Merged
merged 5 commits into from
May 21, 2024
Merged

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented May 21, 2024

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

  • remove some add index ddl, each one will reduce 2 seconds.
  • combine insert into to one txn.
  • remove some excessive data

There is a problem. Now after distask is enabled, adding an index to an empty table takes round 2 seconds, which will cause integrationtest to slow down.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Defined2014 Defined2014 added the skip-issue-check Indicates that a PR no need to check linked issue. label May 21, 2024
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 21, 2024
Copy link

tiprow bot commented May 21, 2024

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 21, 2024
@Defined2014 Defined2014 requested review from xhebox and tangenta May 21, 2024 02:31
Copy link

ti-chi-bot bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 21, 2024
Copy link

ti-chi-bot bot commented May 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-21 02:29:01.049277137 +0000 UTC m=+2138694.806412695: ☑️ agreed by hawkingrei.
  • 2024-05-21 02:37:28.086441274 +0000 UTC m=+2139201.843576842: ☑️ agreed by xhebox.

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.6556%. Comparing base (491740b) to head (bc52016).
Report is 18 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53426        +/-   ##
================================================
+ Coverage   72.5147%   73.6556%   +1.1408%     
================================================
  Files          1498       1523        +25     
  Lines        429925     436966      +7041     
================================================
+ Hits         311759     321850     +10091     
+ Misses        98883      95144      -3739     
- Partials      19283      19972       +689     
Flag Coverage Δ
integration 48.9376% <ø> (?)
unit 71.3545% <ø> (-0.0565%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 42.5310% <ø> (+0.9300%) ⬆️

@Defined2014
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented May 21, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 2e756fc into pingcap:master May 21, 2024
20 of 21 checks passed
@Defined2014 Defined2014 deleted the speed-up-ft branch May 21, 2024 04:30
RidRisR pushed a commit to RidRisR/tidb that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants