Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix mpp final agg couldn't co-exist with other non-final mode #53455

Merged
merged 4 commits into from
May 22, 2024

Conversation

AilinKid
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #51362

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

planner: fix mpp final agg couldn't co-exist with non-final mode

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 21, 2024
Copy link

tiprow bot commented May 21, 2024

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@AilinKid AilinKid changed the title planner: fix mpp final agg couldn't co-exist with non-final mode planner: fix mpp final agg couldn't co-exist with other non-final mode May 21, 2024
AilinKid added 2 commits May 21, 2024 21:26
.
Signed-off-by: AilinKid <[email protected]>
.
Signed-off-by: AilinKid <[email protected]>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 82.92683% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 73.7585%. Comparing base (2d552c0) to head (9f3e1ac).
Report is 51 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53455        +/-   ##
================================================
+ Coverage   72.4523%   73.7585%   +1.3061%     
================================================
  Files          1493       1524        +31     
  Lines        429365     443424     +14059     
================================================
+ Hits         311085     327063     +15978     
+ Misses        99001      96144      -2857     
- Partials      19279      20217       +938     
Flag Coverage Δ
integration 49.1316% <41.4634%> (?)
unit 71.3338% <82.9268%> (-0.0166%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 42.0900% <ø> (+0.6665%) ⬆️

.
Signed-off-by: AilinKid <[email protected]>
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 21, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 22, 2024
Copy link

ti-chi-bot bot commented May 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-21 13:29:30.284416194 +0000 UTC m=+2178324.041551766: ☑️ agreed by winoros.
  • 2024-05-22 05:24:19.682274592 +0000 UTC m=+2235613.439410161: ☑️ agreed by time-and-fate.

@AilinKid AilinKid added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label May 22, 2024
Copy link

ti-chi-bot bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: time-and-fate, winoros, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit 6928519 into pingcap:master May 22, 2024
23 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 22, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #53475.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #53476.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
5 participants