-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: refactor write merge-global-stats #53549
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53549 +/- ##
================================================
+ Coverage 72.4150% 75.1044% +2.6894%
================================================
Files 1505 1507 +2
Lines 430553 437239 +6686
================================================
+ Hits 311785 328386 +16601
+ Misses 99448 88852 -10596
- Partials 19320 20001 +681
Flags with carried forward coverage won't be shown. Click here to find out more.
|
13c6f12
to
02c9feb
Compare
Signed-off-by: Weizhen Wang <[email protected]>
f0eafeb
to
b33b276
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file name is quite confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
write_merge_global.go
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we keep it in the global_stats.go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, it is in the global_stats.go
.
/retest |
1 similar comment
/retest |
Signed-off-by: Weizhen Wang <[email protected]>
6f76e25
to
636e473
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, hi-rustin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What changed and how does it work?
In the future, we will add concurrently global stats writing here.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.