Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: turn off zstd decoding concurrency #53589

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

lance6716
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #53587

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

check it works using a generated large dataset

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 27, 2024
Copy link

tiprow bot commented May 27, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 75.4728%. Comparing base (e6d1899) to head (b554a01).
Report is 49 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53589        +/-   ##
================================================
+ Coverage   74.4090%   75.4728%   +1.0637%     
================================================
  Files          1505       1529        +24     
  Lines        357373     452233     +94860     
================================================
+ Hits         265918     341313     +75395     
- Misses        72128      90309     +18181     
- Partials      19327      20611      +1284     
Flag Coverage Δ
integration 52.9721% <44.4444%> (?)
unit 71.9093% <100.0000%> (-1.3647%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 57.8032% <ø> (+1.5061%) ⬆️
parser ∅ <ø> (∅)
br 50.3502% <ø> (+7.2893%) ⬆️

@lance6716
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented May 31, 2024

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 31, 2024
Copy link

ti-chi-bot bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 3, 2024
Copy link

ti-chi-bot bot commented Jun 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-31 03:03:09.735278573 +0000 UTC m=+3004743.492414138: ☑️ agreed by D3Hunter.
  • 2024-06-03 07:29:11.127571219 +0000 UTC m=+3279904.884706792: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit c6e6c15 into pingcap:master Jun 3, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants