Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: move server.TokenLimiter into util #53598

Merged
merged 1 commit into from
May 28, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented May 28, 2024

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

just remove the code. it will be convenient for developers to use it.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels May 28, 2024
@hawkingrei hawkingrei added skip-issue-check Indicates that a PR no need to check linked issue. do-not-merge/needs-tests-checked labels May 28, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 28, 2024
@hawkingrei hawkingrei requested a review from Defined2014 May 28, 2024 02:34
Copy link

ti-chi-bot bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 28, 2024
Copy link

ti-chi-bot bot commented May 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-28 02:34:16.074850206 +0000 UTC m=+2743809.831985776: ☑️ agreed by xhebox.
  • 2024-05-28 02:36:11.344922331 +0000 UTC m=+2743925.102057904: ☑️ agreed by Defined2014.

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.5339%. Comparing base (57d0b40) to head (35ad2aa).

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53598        +/-   ##
================================================
+ Coverage   72.4865%   74.5339%   +2.0473%     
================================================
  Files          1506       1507         +1     
  Lines        430600     430647        +47     
================================================
+ Hits         312127     320978      +8851     
+ Misses        99241      89783      -9458     
- Partials      19232      19886       +654     
Flag Coverage Δ
integration 49.1561% <100.0000%> (?)
unit 71.3515% <100.0000%> (-0.1146%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.3790% <ø> (+8.9784%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit 97aac23 into pingcap:master May 28, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants