table: memoize TableCommon.getCols

[ekexium]

What problem does this PR solve?

Issue Number: close #53604

Problem Summary:

getCols does duplicated calculation, which wastes CPU time.

What changed and how does it work?

Memoize this function.

Proportion of time in the microbenchmark of AddRecord (with pipelined DML and ART memdb)

Previous:

This PR:

Check List

Tests

• Unit test - micro benchmark + existing test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @ekexium. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Defined2014]

Maybe we could use hiddenColumns, visibleColumns and publicColumns instead of this one.

[ekexium]

When are these fields supposed to be set (before this PR)? I don't find anywhere initializing them

[Defined2014]

Seems never be setted. /cc @zimulala

[ekexium]

Seems #50062 introduced the regression. It removed the default initialization, but mistakenly making them never initialized.

[codecov]

Codecov Report

Attention: Patch coverage is 97.05882% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 74.8076%. Comparing base (df64c34) to head (d2755c1).
Report is 29 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #53605        +/-   ##
================================================
+ Coverage   72.4222%   74.8076%   +2.3854%     
================================================
  Files          1505       1507         +2     
  Lines        430553     438363      +7810     
================================================
+ Hits         311816     327929     +16113     
+ Misses        99427      90324      -9103     
- Partials      19310      20110       +800     

Flag	Coverage Δ
integration	49.4569% <77.9411%> (?)
unit	71.4283% <97.0588%> (+0.0267%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (ø)
parser	∅ <ø> (∅)
br	50.4742% <ø> (+9.0871%)	⬆️

[ekexium]

Test failed because IMPORT INTO concurrently calls AddRecord, which calls WritableConstraint(), resulting in data race.
I'd rather let the caller that knows its concurrent behavior initialize these fields than introducing something like sync.Once here.

[ekexium]

/retest

[tiprow]

@ekexium: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[zimulala]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/table/OWNERS [zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-05-29 06:57:36.091251401 +0000 UTC m=+2846009.848386973: ☑️ agreed by Defined2014.
• 2024-05-29 07:28:48.600745154 +0000 UTC m=+2847882.357880725: ☑️ agreed by zimulala.

[ekexium]

/retest

[tiprow]

@ekexium: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.