Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: fix insert err after import for AUTO_ID_CACHE=1 and SHARD_ROW_ID_BITS (#52712) #53704

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52712

What problem does this PR solve?

Issue Number: close #52654

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
mysql> CREATE TABLE t (
    ->   id bigint(20) unsigned NOT NULL AUTO_INCREMENT,
    ->   PRIMARY KEY (id) /*T![clustered_index] NONCLUSTERED */
    -> ) /*T![auto_id_cache] AUTO_ID_CACHE=1 */ /*T! SHARD_ROW_ID_BITS=4 PRE_SPLIT_REGIONS=3 */;
Query OK, 0 rows affected (0.09 sec)

mysql>
mysql> import into t from select 1778961125641936898;
Query OK, 1 row affected (0.30 sec)
Records: 1, ID: 0e8a4adb-47df-4790-a237-5a489e25d9c6

mysql> insert into t values ();
Query OK, 1 row affected (0.01 sec)

mysql> select *, _tidb_rowid from t;
+---------------------+---------------------+
| id                  | _tidb_rowid         |
+---------------------+---------------------+
| 1778961125641936898 | 1152921504606846977 |
| 1778961125641936899 | 2882303761517117442 |
+---------------------+---------------------+
2 rows in set (0.01 sec)
mysql> select *, _tidb_rowid & x'07FFFFFFFFFFFFFF' from t;
+---------------------+-----------------------------------+
| id                  | _tidb_rowid & x'07FFFFFFFFFFFFFF' |
+---------------------+-----------------------------------+
| 1778961125641936899 |                                 2 |
| 1778961125641936898 |                                 1 |
+---------------------+-----------------------------------+
2 rows in set (0.01 sec)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels May 31, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 31, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 31, 2024
@lance6716
Copy link
Contributor

@D3Hunter please fix the conflict

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 3, 2024
@D3Hunter
Copy link
Contributor

D3Hunter commented Jun 3, 2024

/run-integration-br-test

@D3Hunter
Copy link
Contributor

D3Hunter commented Jun 3, 2024

/test ?

Copy link

ti-chi-bot bot commented Jun 3, 2024

@D3Hunter: The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test pull-br-integration-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/release-6.5/ghpr_build
  • pingcap/tidb/release-6.5/ghpr_check
  • pingcap/tidb/release-6.5/ghpr_check2
  • pingcap/tidb/release-6.5/ghpr_mysql_test
  • pingcap/tidb/release-6.5/ghpr_unit_test

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter
Copy link
Contributor

D3Hunter commented Jun 3, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Jun 3, 2024

@D3Hunter: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

tiprow bot commented Jun 3, 2024

@D3Hunter: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter
Copy link
Contributor

D3Hunter commented Jun 3, 2024

/test pull-br-integration-test

Copy link

ti-chi-bot bot commented Jun 3, 2024

@D3Hunter: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test pull-br-integration-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/release-6.5/ghpr_build
  • pingcap/tidb/release-6.5/ghpr_check
  • pingcap/tidb/release-6.5/ghpr_check2
  • pingcap/tidb/release-6.5/ghpr_mysql_test
  • pingcap/tidb/release-6.5/ghpr_unit_test

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Jun 3, 2024

@D3Hunter: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter
Copy link
Contributor

D3Hunter commented Jun 3, 2024

/test pull-br-integration-test

Copy link

ti-chi-bot bot commented Jun 3, 2024

@D3Hunter: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test pull-br-integration-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/release-6.5/ghpr_build
  • pingcap/tidb/release-6.5/ghpr_check
  • pingcap/tidb/release-6.5/ghpr_check2
  • pingcap/tidb/release-6.5/ghpr_mysql_test
  • pingcap/tidb/release-6.5/ghpr_unit_test

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Jun 3, 2024

@D3Hunter: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter
Copy link
Contributor

D3Hunter commented Jun 3, 2024

/test pull-br-integration-test

Copy link

ti-chi-bot bot commented Jun 3, 2024

@D3Hunter: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test pull-br-integration-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/release-6.5/ghpr_build
  • pingcap/tidb/release-6.5/ghpr_check
  • pingcap/tidb/release-6.5/ghpr_check2
  • pingcap/tidb/release-6.5/ghpr_mysql_test
  • pingcap/tidb/release-6.5/ghpr_unit_test

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter D3Hunter changed the title lightning/importinto: fix insert err after import for AUTO_ID_CACHE=1 and SHARD_ROW_ID_BITS (#52712) lightning: fix insert err after import for AUTO_ID_CACHE=1 and SHARD_ROW_ID_BITS (#52712) Jun 3, 2024
Copy link

tiprow bot commented Jun 3, 2024

@D3Hunter: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter
Copy link
Contributor

D3Hunter commented Jun 3, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Jun 3, 2024

@D3Hunter: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 41.30435% with 27 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-6.5@d9c5bf6). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #53704   +/-   ##
================================================
  Coverage               ?   73.6641%           
================================================
  Files                  ?       1096           
  Lines                  ?     351688           
  Branches               ?          0           
================================================
  Hits                   ?     259068           
  Misses                 ?      75976           
  Partials               ?      16644           

@D3Hunter
Copy link
Contributor

D3Hunter commented Jun 3, 2024

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Jun 3, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 3, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 4, 2024
Copy link

ti-chi-bot bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jun 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-03 13:04:35.95311393 +0000 UTC m=+3300029.710249498: ☑️ agreed by D3Hunter.
  • 2024-06-04 02:08:03.571807183 +0000 UTC m=+3347037.328942757: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit 42669ad into pingcap:release-6.5 Jun 4, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants