-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: fix wrong NDV in the global stats when to disable async-merge-global-stats (#53762) #53803
Merged
ti-chi-bot
merged 5 commits into
pingcap:release-6.5
from
ti-chi-bot:cherry-pick-53762-to-release-6.5
Jun 5, 2024
Merged
statistics: fix wrong NDV in the global stats when to disable async-merge-global-stats (#53762) #53803
ti-chi-bot
merged 5 commits into
pingcap:release-6.5
from
ti-chi-bot:cherry-pick-53762-to-release-6.5
Jun 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <[email protected]>
Merged
13 tasks
Signed-off-by: Weizhen Wang <[email protected]>
hawkingrei
approved these changes
Jun 4, 2024
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Rustin170506
approved these changes
Jun 5, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, hi-rustin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
hawkingrei
pushed a commit
to hawkingrei/tidb
that referenced
this pull request
Jul 1, 2024
…erge-global-stats (pingcap#53762) (pingcap#53803) close pingcap#53752
hawkingrei
pushed a commit
to hawkingrei/tidb
that referenced
this pull request
Jul 1, 2024
…erge-global-stats (pingcap#53762) (pingcap#53803) close pingcap#53752
Merged
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
lgtm
release-note-none
Denotes a PR that doesn't merit a release note.
sig/planner
SIG: Planner
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
type/cherry-pick-for-release-6.5
This PR is cherry-picked to release-6.5 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #53762
What problem does this PR solve?
Issue Number: close #53752
Problem Summary:
What changed and how does it work?
blockMergeGlobalStats doesn't notice that FMSketch contains empty objectives in all partition's stats. so we need to find nil to init global rightly.
Check List
Tests
run as the PR's description.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.