Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: optimize executor runtime stats by avoid unnecessary clone #54004

Merged
merged 6 commits into from
Dec 8, 2024

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Jun 13, 2024

What problem does this PR solve?

Issue Number: ref #56649

Problem Summary: Optimize executor runtime stats by avoid unnecessary clone.

What changed and how does it work?

  • Optimize executor runtime stats by avoid unnecessary clone.
image
  • Tiny optimize index usage reporter for point_get.
version workload thread QPS QPS Increase
master oltp_point_select 10 17156  
This PR oltp_point_select 10 17365 1.2 %
master oltp_point_select 100 85664  
This PR oltp_point_select 100 86774 1.2%

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

ti-chi-bot bot commented Jun 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 13, 2024
@crazycs520 crazycs520 marked this pull request as ready for review June 13, 2024 09:22
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 13, 2024
Copy link

tiprow bot commented Jun 13, 2024

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.2204%. Comparing base (9812d85) to head (112619c).
Report is 20 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #54004        +/-   ##
================================================
+ Coverage   73.1839%   74.2204%   +1.0364%     
================================================
  Files          1671       1674         +3     
  Lines        460731     467199      +6468     
================================================
+ Hits         337181     346757      +9576     
+ Misses       102827      99691      -3136     
- Partials      20723      20751        +28     
Flag Coverage Δ
integration 43.7328% <8.3333%> (?)
unit 72.9371% <100.0000%> (+0.6319%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 46.0434% <ø> (+0.0390%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 13, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 3, 2024
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
@crazycs520 crazycs520 changed the title executor: avoid unnecessary clone[DNM] executor: optimize executor runtime stats by avoid unnecessary clone Dec 4, 2024
@crazycs520
Copy link
Contributor Author

/retest-required

Copy link

tiprow bot commented Dec 4, 2024

@crazycs520: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cfzjywxk cfzjywxk requested review from cfzjywxk, zyguan and you06 December 6, 2024 02:47
@cfzjywxk cfzjywxk requested a review from ekexium December 6, 2024 02:47
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 8, 2024
Copy link

ti-chi-bot bot commented Dec 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 8, 2024
Copy link

ti-chi-bot bot commented Dec 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-08 03:49:11.788475902 +0000 UTC m=+151141.877278446: ☑️ agreed by zyguan.
  • 2024-12-08 08:04:37.569638176 +0000 UTC m=+166467.658440716: ☑️ agreed by cfzjywxk.

@ti-chi-bot ti-chi-bot bot merged commit 56c07d0 into pingcap:master Dec 8, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants