-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: update prow OWNERS_ALIASES file #54195
*: update prow OWNERS_ALIASES file #54195
Conversation
This reverts commit 3d3afe7.
Hi @wuhuizuo. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/hold |
/hold |
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #46911
Problem Summary:
What changed and how does it work?
Reverts #54174
Although the code owners of a directory do not conflict with the community member mechanism of the repository, the exit mechanism of the code owners of the directory still needs to be determined(ref: https://internals.tidb.io/t/topic/877
).
Only the repository "/OWNERS" file will be synchronized with the member list in pingcap/community, in which members can participate in the review of the entire repository. However, for subdirectories configured with the "OWNERS" file, the code owners of the directory are needed to determine whether they can be merged.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.