*: improve ErrKeyExists generation and MemoizeStr #54412
Conversation
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-tests-checked
release-note-none
|
Hi @lance6716. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: lance6716 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54412 +/- ##
=================================================
- Coverage 72.8354% 56.2697% -16.5658%
=================================================
Files 1535 1652 +117
Lines 435896 603962 +168066
=================================================
+ Hits 317487 339848 +22361
- Misses 98795 240821 +142026
- Partials 19614 23293 +3679
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pkg/table/tables/tables.go
Outdated
| @@ -1165,11 +1165,11 @@ func (t *TableCommon) addIndices(sctx table.MutateContext, recordID kv.Handle, r | |||
| if !skipCheck && v.Meta().Unique { | |||
| // Make error message consistent with MySQL. | |||
| tablecodec.TruncateIndexValues(t.meta, v.Meta(), indexVals) | |||
| entryKey, err := genIndexKeyStr(indexVals) | |||
| entryKey, err := genIndexKeyStrs(indexVals) | |||
There was a problem hiding this comment.
| entryKey, err := genIndexKeyStrs(indexVals) | |
| colStrVals, err := genIndexKeyStrs(indexVals) |
There was a problem hiding this comment.
there are a few in below code, can change them together
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: lance6716 <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, D3Hunter, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #53004
Problem Summary:
What changed and how does it work?
MemoizeStrdoes not cache the computed result after util: clean up MemoizeStr function #11450, this PR reverts it.GenKeyExistsErrto ensure using[]stringas argumentCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.