executor/simple: prohibit setting a resource group to a role #54525
Conversation
ti-chi-bot
bot
added
release-note-none
|
/cc @nolouch @CbcWestwolf @tangenta PTAL, thx. |
Signed-off-by: JmPotato <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54525 +/- ##
=================================================
- Coverage 72.8280% 56.0809% -16.7471%
=================================================
Files 1546 1667 +121
Lines 436236 609055 +172819
=================================================
+ Hits 317702 341564 +23862
- Misses 98945 244161 +145216
- Partials 19589 23330 +3741
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -379,6 +379,11 @@ create user user1; | |||
| ALTER USER `user1` RESOURCE GROUP `rg1`; | |||
| SELECT CURRENT_RESOURCE_GROUP(); | |||
|
|
|||
| create role role_for_resource_group; | |||
There was a problem hiding this comment.
Please add a simple create role role_for_resource_group resource group rg1; to cover s.IsCreateRole branch in executeCreateUser
There was a problem hiding this comment.
CREATE ROLE syntax doesn't support setting the resource group, so it will directly return an error when parsing the SQL.
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CbcWestwolf, nolouch, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/cherry-pick release-7.5 |
Signed-off-by: ti-chi-bot <[email protected]>
|
@JmPotato: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/cherry-pick release-8.1 |
|
@nolouch: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/cherry-pick release-7.1 |
Signed-off-by: ti-chi-bot <[email protected]>
|
@JmPotato: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #54417, ref #54434.
What changed and how does it work?
Check if a user is a role before assigning a resource group to it.
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.