Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: fix sync load fails after disabling lite init stats #54531

Merged
merged 7 commits into from
Aug 27, 2024
Merged

statistics: fix sync load fails after disabling lite init stats #54531

merged 7 commits into from
Aug 27, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jul 9, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #54532

Problem Summary:

What changed and how does it work?

after #53399, we don't load the common column's stats into the cache. so it also cannot init the infoschema in the stats structure. so it will lead the problem, which cannot sync load

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 9, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.84615% with 11 lines in your changes missing coverage. Please review.

Project coverage is 74.8414%. Comparing base (4eeeef8) to head (4b67142).
Report is 8 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #54531        +/-   ##
================================================
+ Coverage   72.9214%   74.8414%   +1.9199%     
================================================
  Files          1581       1582         +1     
  Lines        442336     442784       +448     
================================================
+ Hits         322558     331386      +8828     
+ Misses        99970      91166      -8804     
- Partials      19808      20232       +424
Flag Coverage Δ
integration 49.1707% <78.8461%> (?)
unit 71.9457% <73.0769%> (-0.0554%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.1931% <ø> (+6.9140%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Jul 9, 2024
@hawkingrei hawkingrei force-pushed the fix_cannot_sync_load_close_lite branch from 7a80598 to 6f18b1f Compare July 10, 2024 02:16
@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei requested a review from winoros July 10, 2024 06:46
@hawkingrei hawkingrei force-pushed the fix_cannot_sync_load_close_lite branch 2 times, most recently from 9923a4e to 35a2237 Compare July 10, 2024 07:04
@hawkingrei hawkingrei requested a review from Rustin170506 July 10, 2024 08:02
@hawkingrei hawkingrei force-pushed the fix_cannot_sync_load_close_lite branch from dec0852 to 3fd13fd Compare July 10, 2024 10:13
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 10, 2024
@hawkingrei hawkingrei force-pushed the fix_cannot_sync_load_close_lite branch from 4925b62 to 3fd13fd Compare July 10, 2024 15:12
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 10, 2024
@hawkingrei hawkingrei force-pushed the fix_cannot_sync_load_close_lite branch from 84b0d15 to 9617a46 Compare July 10, 2024 16:03
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei force-pushed the fix_cannot_sync_load_close_lite branch 2 times, most recently from 714295c to ee73a33 Compare July 11, 2024 00:56
@hawkingrei hawkingrei changed the title statistics: fix sync load fails after disabling lite init stats statistics: fix sync load fails after disabling lite init stats [WIP] Jul 11, 2024
@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2024
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei changed the title statistics: fix sync load fails after disabling lite init stats | tidb-test=pr/2383 statistics: fix sync load fails after disabling lite init stats Aug 27, 2024
@hawkingrei
Copy link
Member Author

/test all

@hawkingrei hawkingrei force-pushed the fix_cannot_sync_load_close_lite branch 2 times, most recently from b02f6c6 to 8b6e837 Compare August 27, 2024 04:01
@hawkingrei hawkingrei changed the title statistics: fix sync load fails after disabling lite init stats statistics: fix sync load fails after disabling lite init stats | tidb-test=pr/2383 Aug 27, 2024
@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/test all

@hawkingrei hawkingrei changed the title statistics: fix sync load fails after disabling lite init stats | tidb-test=pr/2383 statistics: fix sync load fails after disabling lite init stats Aug 27, 2024
@hawkingrei
*: fix test
f37db7d 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: fix test
ec001a8 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: fix test
609a116 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: fix test
3164d22 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
*: fix test
4b67142 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, D3Hunter, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hawkingrei
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2024
@hawkingrei
Copy link
Member Author

/retest

2 similar comments
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 87244ed into pingcap:master Aug 27, 2024
23 checks passed
@hawkingrei hawkingrei deleted the fix_cannot_sync_load_close_lite branch August 28, 2024 05:40
hawkingrei added a commit that referenced this pull request Aug 28, 2024
@hawkingrei
Revert "statistics: fix sync load fails after disabling lite init sta…
fb79b87 
…ts (#54531)"

This reverts commit 87244ed.
@hawkingrei hawkingrei mentioned this pull request Aug 28, 2024
Closed
@D3Hunter D3Hunter mentioned this pull request Aug 28, 2024
Closed
13 tasks
@lcwangchao lcwangchao mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

@winoros winoros winoros approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inconsistency explain bewteen lite-init-stats and non-lite-init-stats
4 participants
@hawkingrei @D3Hunter @winoros @AilinKid