Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: Accept PASSWORD REQUIRE CURRENT DEFAULT (#53306) #54559

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #53306

What problem does this PR solve?

Issue Number: close #53305

Problem Summary:

  1. This only accepts CREATE USER ... PASSWORD REQUIRE CURRENT DEFAULT. It doesn't support PASSWORD REQUIRE CURRENT OPTIONAL.
  2. This isn't stored, checked or validated.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

TiDB now accepts `PASSWORD REQUIRE CURRENT DEFAULT` as part of `CREATE USER` to aid MySQL 8.0 compatibility

@ti-chi-bot ti-chi-bot added component/parser ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 11, 2024
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. label Jul 11, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 11, 2024
@dveeden
Copy link
Contributor

dveeden commented Jul 11, 2024

/retest

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.5@112a821). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #54559   +/-   ##
================================================
  Coverage               ?   71.9978%           
================================================
  Files                  ?       1412           
  Lines                  ?     410958           
  Branches               ?          0           
================================================
  Hits                   ?     295881           
  Misses                 ?      95181           
  Partials               ?      19896           
Flag Coverage Δ
unit 71.9978% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.4477% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2024
@YangKeao YangKeao force-pushed the cherry-pick-53306-to-release-7.5 branch from 2afa00b to e66c8ad Compare July 12, 2024 05:39
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2024
@YangKeao
Copy link
Member

/retest

@YangKeao YangKeao requested review from bb7133 and YangKeao July 12, 2024 06:37
@YangKeao
Copy link
Member

/retest

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 15, 2024
@YangKeao YangKeao requested a review from tangenta July 15, 2024 08:05
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bb7133, YangKeao
Once this PR has been reviewed and has the lgtm label, please assign bb7133, yudongusa for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 22, 2024
Copy link

ti-chi-bot bot commented Jul 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-15 08:02:14.799286938 +0000 UTC m=+254556.790228400: ☑️ agreed by YangKeao.
  • 2024-07-22 03:24:34.209507489 +0000 UTC m=+842696.200448959: ☑️ agreed by bb7133.

@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jul 22, 2024
@ti-chi-bot ti-chi-bot closed this Jul 22, 2024
Copy link

ti-chi-bot bot commented Jul 22, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/parser do-not-merge/cherry-pick-not-approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants