Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add //go:build ignore to the main files in tools/check #54654

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Jul 16, 2024

What problem does this PR solve?

Issue Number: close #54653

Problem Summary:

The VSCode keeps complaining about the duplicated main function in that folder.

image

What changed and how does it work?

Adding //go:build ignore to these files. It should work fine as they are simple go scripts and the folder don't need to be considered as a package.

Ref golang/go#49657

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

    If this change didn't break CI, it means it's good enough.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 16, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 16, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 16, 2024
Copy link

ti-chi-bot bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 16, 2024
Copy link

ti-chi-bot bot commented Jul 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-16 05:34:54.942138326 +0000 UTC m=+332116.933079796: ☑️ agreed by hawkingrei.
  • 2024-07-16 05:48:28.536648608 +0000 UTC m=+332930.527590078: ☑️ agreed by Defined2014.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.9453%. Comparing base (ee9f58c) to head (c85165f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54654         +/-   ##
=================================================
- Coverage   72.7475%   55.9453%   -16.8022%     
=================================================
  Files          1551       1672        +121     
  Lines        436702     608842     +172140     
=================================================
+ Hits         317690     340619      +22929     
- Misses        99442     244916     +145474     
- Partials      19570      23307       +3737     
Flag Coverage Δ
integration 37.2007% <ø> (?)
unit 71.7114% <ø> (-0.0548%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 52.5609% <ø> (+6.7118%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit ce0204a into pingcap:master Jul 16, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSCode keeps complaining the duplicated declaration in /tools/check folder
3 participants