expression: expose the optional property on EvaluatorSuit #54798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Keao <[email protected]>
ti-chi-bot
bot
added
release-note-none
lcwangchao
approved these changes
Jul 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #54798 +/- ##
=================================================
- Coverage 74.7413% 57.1398% -17.6015%
=================================================
Files 1555 1681 +126
Lines 363372 620843 +257471
=================================================
+ Hits 271589 354749 +83160
- Misses 72138 242738 +170600
- Partials 19645 23356 +3711
Flags with carried forward coverage won't be shown. Click here to find out more.
|
XuHuaiyu
approved these changes
Jul 23, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #54797
Problem Summary:
Expose the optional property on the
EvaluatorSuit. It can help us to implement theDetachfunction forProjectionExecandSelectionExec.What changed and how does it work?
It recursively reads the optional property of all expressions and their arguments.
Check List
Tests
Release note