meta,infoschema: fix a bug that after HasTemporaryTable() wrong infoschema v2 full load

[tiancaiamao]

What problem does this PR solve?

Issue Number: ref #50959

Problem Summary:

In infoschema v2 full load, we don't read the model.TableInfo for temporary tables, the temporary table is not added.
So after a full load, the HasHasTemporaryTable() returns false even maybe there are some temporary tables.

What changed and how does it work?

Load name => model.TableInfo for temporary tables.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[wjhuang2016]

Please update hasSpecialAttributes() too.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.7729%. Comparing base (cf4bb51) to head (ca60a22).
Report is 21 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #54879        +/-   ##
================================================
+ Coverage   74.7249%   74.7729%   +0.0479%     
================================================
  Files          1558       1568        +10     
  Lines        363817     452264     +88447     
================================================
+ Hits         271862     338171     +66309     
- Misses        72284      93256     +20972     
- Partials      19671      20837      +1166     

Flag	Coverage Δ
integration	50.1515% <100.0000%> (?)
unit	71.6425% <100.0000%> (-1.9704%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9567% <ø> (-2.2327%)	⬇️
parser	∅ <ø> (∅)
br	52.4028% <ø> (+4.6762%)	⬆️

[tiancaiamao]

Please update hasSpecialAttributes() too.

Temporary tables do not need to be keep in-memory, there is no background worker loop visiting it.
To handle the HasTemporaryTable() bug, change the load process to load table info for temporary tables is enough.

@wjhuang2016

[tiancaiamao]

/retest

[tiprow]

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/domain/OWNERS [lance6716,wjhuang2016]
• pkg/infoschema/OWNERS [wjhuang2016]
• pkg/meta/OWNERS [wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-07-29 02:58:41.135420796 +0000 UTC m=+151837.415468865: ☑️ agreed by lance6716.
• 2024-07-29 07:28:27.120464928 +0000 UTC m=+168023.400512997: ☑️ agreed by wjhuang2016.