-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor, infoschema: filter out the PRIMARY index and foreign keys in table_constraints #55255
Conversation
/hold Wait a minute. I'm checking the tests. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55255 +/- ##
================================================
+ Coverage 72.8486% 74.8320% +1.9833%
================================================
Files 1570 1573 +3
Lines 439518 442229 +2711
================================================
+ Hits 320183 330929 +10746
+ Misses 99610 90973 -8637
- Partials 19725 20327 +602
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Yang Keao <[email protected]>
/unhold |
/test pull-integration-common-test |
/test pull-integration-nodejs-test |
@YangKeao: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@YangKeao: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #55253
Problem Summary:
The previous patch https://github.com/pingcap/tidb/pull/55236/files#diff-cd85979e0fe90c288bf582cb1b181f51cbb7b874423cc4e1163617e2dbf95c98R2140-R2142 forgot to filter the
PRIMARY
index and the foreign keys. This PR fixes this issue.What changed and how does it work?
Add two filters condition on PRIMARY index and foreign keys.
It'd be better to have a function to automatically check all
record
s according to the extracted column and defined columns in the table, and replace all manualappend(rows, record)
. However, @tangenta told me he's working on rewriting the extractor and making every table has its own retriever, so I only submit some temporary fixes.Check List
Tests
Release note