-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: incorrect query result using ISNULL in the nested expressions #55306
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55306 +/- ##
================================================
- Coverage 74.8217% 74.7086% -0.1132%
================================================
Files 1572 1572
Lines 365097 440890 +75793
================================================
+ Hits 273172 329383 +56211
- Misses 72157 91312 +19155
- Partials 19768 20195 +427
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #55299
Problem Summary:
What changed and how does it work?
in the https://github.com/pingcap/tidb/pull/54819, We prevent
isnull(xxx)
to transfer=null
. but it is wrong. we should transfer it into the right way in thepoints2EqOrInCond
for the example, if we meet
column1
with[null,1,2,3]
putting into thepoints2EqOrInCond
. it should returnisnull(column1) or column1 in (1,2,3)
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.