table: make AddRecordOpt/UpdateRecordOpt/CreateIdxOpt immutable

[lcwangchao]

What problem does this PR solve?

Issue Number: ref #54397

Problem Summary:

We should to make XXXOpt in table immutable to avoid some potential bugs introduced by modifying its inner state and then shared with other operations. See issue: #55313

What changed and how does it work?

• Make the fields in the opt objects private to avoid modification directly in other package.
• Make the method in the interfaces AddRecordOption / UpdateRecordOption / CreateIdxOption private to forbid outside package to use them.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lcwangchao]

/retest

[tiprow]

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.8394%. Comparing base (2a731e6) to head (d703a45).
Report is 2 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #55325        +/-   ##
================================================
+ Coverage   72.8378%   74.8394%   +2.0016%     
================================================
  Files          1570       1570                
  Lines        439564     440563       +999     
================================================
+ Hits         320169     329715      +9546     
+ Misses        99701      90647      -9054     
- Partials      19694      20201       +507     

Flag	Coverage Δ
integration	49.0766% <94.3396%> (?)
unit	71.9630% <100.0000%> (+0.0905%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9567% <ø> (ø)
parser	∅ <ø> (∅)
br	52.5154% <ø> (+6.6399%)	⬆️

[lcwangchao]

Also delete CreateIdxOptFunc to avoid some operations like WithIgnoreAssertion(createIdxOpt) to modify the internal state of CreateIdxOpt.

[cfzjywxk]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/table/OWNERS [cfzjywxk,wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-08-09 07:13:30.134014288 +0000 UTC m=+595340.001113376: ☑️ agreed by cfzjywxk.
• 2024-08-09 07:20:29.235238255 +0000 UTC m=+595759.102337343: ☑️ agreed by wjhuang2016.