-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
table: Add PessimisticLazyDupKeyCheckMode
to determine lazy mode in pessimistic txn
#55360
Conversation
Hi @lcwangchao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6c7dada
to
4e5b3cc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55360 +/- ##
================================================
- Coverage 74.9797% 73.9827% -0.9970%
================================================
Files 1576 1576
Lines 365580 440666 +75086
================================================
+ Hits 274111 326017 +51906
- Misses 71737 94715 +22978
- Partials 19732 19934 +202
Flags with carried forward coverage won't be shown. Click here to find out more.
|
4e5b3cc
to
dd875ed
Compare
dd875ed
to
f2f3d98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #54397
What changed and how does it work?
This PR introduced a new table option
PessimisticLazyDupKeyCheckMode
to determine the lazy check mode in pessimistic mode. It has two values:If
PessimisticLazyDupKeyCheckMode
is not specified, it is defaulted toPessimisticKeyCheckInLock
.PessimisticLazyDupKeyCheckMode
only works whenDupKeyCheckMode
isDupKeyCheckLazy
in pessimistic mode.This PR also removed method
GetSessionVars
intable.MutateContext
to make the context simple.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.