lightning: fix pd leader switch CI after PD upgrading #55498
Conversation
Signed-off-by: lance6716 <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-tests-checked
do-not-merge/work-in-progress
|
Hi @lance6716. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #55498 +/- ##
================================================
+ Coverage 74.8446% 75.5653% +0.7206%
================================================
Files 1576 1598 +22
Lines 365724 450511 +84787
================================================
+ Hits 273725 340430 +66705
- Misses 72209 88775 +16566
- Partials 19790 21306 +1516
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: lance6716 <[email protected]>
ti-chi-bot
bot
added
size/S
lance6716
changed the title
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
| @@ -43,7 +45,7 @@ pd-server --join "https://$PD_ADDR" \ | |||
| killall tidb-server | |||
| # wait for TiDB to exit to release file lock | |||
| sleep 5 | |||
| start_tidb | |||
| PD_ADDR="${PD_ADDR},${PD_ADDR}2,${PD_ADDR}3" start_tidb | |||
There was a problem hiding this comment.
we focus on testing lightning's behaviour of discovering new PD members, not testing TiDB. So passing all PD addresses to TiDB
There was a problem hiding this comment.
The results of this test show that it can still pass the test #55491
https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Fpull_lightning_integration_test/detail/pull_lightning_integration_test/1115/pipeline
There was a problem hiding this comment.
OK, I'll remove it
| @@ -1,6 +1,3 @@ | |||
| lease = 360 | |||
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
|
Maybe need to run the br intergration test ? |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
@lhy1024: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It's run automatically, in a recent change of CI pipeline. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, joccau, Leavrth, lhy1024, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: close #55487
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.