-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: make sure mpp join task's hashCols are all contained of its plan's schema (#52836) #55654
planner: make sure mpp join task's hashCols are all contained of its plan's schema (#52836) #55654
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: yibin <[email protected]>
/cc @winoros |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #55654 +/- ##
================================================
Coverage ? 71.9977%
================================================
Files ? 1413
Lines ? 411778
Branches ? 0
================================================
Hits ? 296471
Misses ? 95420
Partials ? 19887
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #52836
What problem does this PR solve?
Issue Number: close #42587
Problem Summary:
In physical projection elimination, when a projection is above another projection and satisfy certain conditions, we'll remove current projection and use current projection's schema to reset child projection. However,
empty projection(which schema is totally pruned) with projection child, will set child projection's schema to empty, which doesn't make sense. In such situation, keep child projection's schema seems more reasonable.
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.