Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br/ebs: added log for EBS snapshot creation, increase backoff time for creating snapshot #55667

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Aug 26, 2024

…Snapshot

What problem does this PR solve?

Issue Number: close #55672

Problem Summary:
In the past, we use the default retry strategy to back off when create snapshot failed. But the quota for CreateSnapshots is pretty low. Hence sometimes we exceeded the retry limit.
Also there isn't any log when encountered issues, we need log them.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    (TBD)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 26, 2024
@YuJuncen YuJuncen changed the title added log for EBS snapshot creation, increase backoff time for creating snapshot br/ebs: added log for EBS snapshot creation, increase backoff time for creating snapshot Aug 26, 2024
Copy link

tiprow bot commented Aug 26, 2024

Hi @YuJuncen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 59.2756%. Comparing base (4eeeef8) to head (fe72627).
Report is 87 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #55667         +/-   ##
=================================================
- Coverage   72.9214%   59.2756%   -13.6459%     
=================================================
  Files          1581       1760        +179     
  Lines        442336     656850     +214514     
=================================================
+ Hits         322558     389352      +66794     
- Misses        99970     242798     +142828     
- Partials      19808      24700       +4892     
Flag Coverage Δ
integration 42.1012% <0.0000%> (?)
unit 74.4893% <0.0000%> (+2.4883%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.5253% <ø> (+1.5686%) ⬆️
parser ∅ <ø> (∅)
br 64.5436% <0.0000%> (+19.2644%) ⬆️

// Sadly it seems there isn't an exported operation name...
// The quota for create snapshots is 5 per minute.
// Back off for a longer time so we won't excced it.
if r.Operation.Name == "CreateSnapshots" {
Copy link
Contributor

@BornChanger BornChanger Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you even make the backoff logical applicable to more operations.

Signed-off-by: hillium <[email protected]>
@YuJuncen
Copy link
Contributor Author

/test pull-br-integration-test

Copy link

tiprow bot commented Aug 29, 2024

@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Sep 3, 2024

@michaelmdeng: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 4, 2024
Copy link

ti-chi-bot bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth, michaelmdeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 9, 2024
Copy link

ti-chi-bot bot commented Sep 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-04 16:46:04.857135733 +0000 UTC m=+462889.375188657: ☑️ agreed by BornChanger.
  • 2024-09-09 03:06:40.532536421 +0000 UTC m=+239270.272960362: ☑️ agreed by Leavrth.

Copy link

tiprow bot commented Sep 9, 2024

@YuJuncen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow fe72627 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 2d1ed88 into pingcap:master Sep 9, 2024
31 of 32 checks passed
@BornChanger BornChanger added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Sep 9, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #55940.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #55941.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br/ebs: no logging for failed EBS requests, also the retry backoff is too short
5 participants