-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br/ebs: added log for EBS snapshot creation, increase backoff time for creating snapshot #55667
Conversation
…Snapshot Signed-off-by: hillium <[email protected]>
Hi @YuJuncen. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55667 +/- ##
=================================================
- Coverage 72.9214% 59.2756% -13.6459%
=================================================
Files 1581 1760 +179
Lines 442336 656850 +214514
=================================================
+ Hits 322558 389352 +66794
- Misses 99970 242798 +142828
- Partials 19808 24700 +4892
Flags with carried forward coverage won't be shown. Click here to find out more.
|
br/pkg/aws/ebs.go
Outdated
// Sadly it seems there isn't an exported operation name... | ||
// The quota for create snapshots is 5 per minute. | ||
// Back off for a longer time so we won't excced it. | ||
if r.Operation.Name == "CreateSnapshots" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you even make the backoff logical applicable to more operations.
Signed-off-by: hillium <[email protected]>
/test pull-br-integration-test |
@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@michaelmdeng: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, Leavrth, michaelmdeng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
@YuJuncen: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
…Snapshot
What problem does this PR solve?
Issue Number: close #55672
Problem Summary:
In the past, we use the default retry strategy to back off when create snapshot failed. But the quota for
CreateSnapshots
is pretty low. Hence sometimes we exceeded the retry limit.Also there isn't any log when encountered issues, we need log them.
What changed and how does it work?
Check List
Tests
(TBD)
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.