Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: fix sub_part in information_schema.statistics table #55814

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Sep 3, 2024

What problem does this PR solve?

Issue Number: close #55812

Problem Summary: We didn't set sub_part column correctly in information_schema.statistics table, just fix it.
Also found a bug related with mysql-tester. pingcap/mysql-tester#131

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2024
Copy link

tiprow bot commented Sep 3, 2024

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014 Defined2014 changed the title infoschema: fix sub_part in information_schema.statistics table infoschema: fix sub_part in information_schema.statistics table Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.1997%. Comparing base (0583e84) to head (43760c6).
Report is 143 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #55814         +/-   ##
=================================================
- Coverage   72.7958%   56.1997%   -16.5961%     
=================================================
  Files          1588       1714        +126     
  Lines        443469     616161     +172692     
=================================================
+ Hits         322827     346281      +23454     
- Misses       100772     246325     +145553     
- Partials      19870      23555       +3685     
Flag Coverage Δ
integration 37.1378% <100.0000%> (?)
unit 71.9576% <100.0000%> (+0.0510%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.2831% <ø> (+6.8519%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 3, 2024
Copy link

ti-chi-bot bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 3, 2024
Copy link

ti-chi-bot bot commented Sep 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-03 07:47:03.510623619 +0000 UTC m=+344148.028676714: ☑️ agreed by hawkingrei.
  • 2024-09-03 09:04:58.142988512 +0000 UTC m=+348822.661041438: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit 0816166 into pingcap:master Sep 3, 2024
21 of 23 checks passed
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Sep 6, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 6, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #55904.

@Defined2014 Defined2014 added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Sep 23, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 23, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #56208.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #56209.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 23, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 23, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #56210.

Defined2014 added a commit to ti-chi-bot/tidb that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The sub_part in information_schema.statistics table incorrect
4 participants