domain: move UpdateStatsHealthyMetrics into updateStatsWorker (#55386) #56324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
release-note-none
13 tasks
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
cherry-pick-approved
hawkingrei
approved these changes
Nov 4, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
lance6716
approved these changes
Nov 4, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
ti-chi-bot
bot
added
release-note
|
/retest |
1 similar comment
|
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #56324 +/- ##
================================================
Coverage ? 73.4744%
================================================
Files ? 1212
Lines ? 380988
Branches ? 0
================================================
Hits ? 279929
Misses ? 83200
Partials ? 17859 |
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
hawkingrei
force-pushed
the
cherry-pick-55386-to-release-7.1
branch
from
3f5b28f to
0d1cd1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #55386
What problem does this PR solve?
Issue Number: ref #54552
Problem Summary:
What changed and how does it work?
move UpdateStatsHealthyMetrics into updateStatsWorker. This way, it will not compete for resources with sync statistic. because we find that sync stats will pause for too much time to sync stats as soon as possible. it will lead to miss some stats to sync.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.