Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add test for foreign key related to prepare and Non-Transactional DML #56366

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Sep 27, 2024

What problem does this PR solve?

Issue Number: close #56365

Problem Summary:

We didn't have tests for the cooperation between foreign key and PREPARE or Non-Transactional DML. This PR adds these tests.

What changed and how does it work?

Add two tests about the cooperation between foreign key and PREPARE or Non-Transactional DML.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.1456%. Comparing base (73f1cfe) to head (e88925f).
Report is 201 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56366         +/-   ##
=================================================
- Coverage   73.3876%   57.1456%   -16.2421%     
=================================================
  Files          1620       1762        +142     
  Lines        447041     656880     +209839     
=================================================
+ Hits         328073     375378      +47305     
- Misses        98869     256920     +158051     
- Partials      20099      24582       +4483     
Flag Coverage Δ
integration 37.0343% <ø> (?)
unit 72.5534% <ø> (+0.0751%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 50.7613% <ø> (+5.2287%) ⬆️

@YangKeao YangKeao force-pushed the enrich-test-for-foreign-key branch from a6a126b to e88925f Compare October 29, 2024 06:04
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2024
Copy link

tiprow bot commented Oct 29, 2024

@YangKeao: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tidb_parser_test e88925f link true /test tidb_parser_test
fast_test_tiprow e88925f link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 29, 2024
Copy link

ti-chi-bot bot commented Oct 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, Defined2014

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,crazycs520]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 29, 2024
Copy link

ti-chi-bot bot commented Oct 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-29 06:09:54.867992239 +0000 UTC m=+330107.707147784: ☑️ agreed by crazycs520.
  • 2024-10-29 06:16:43.482870334 +0000 UTC m=+330516.322025876: ☑️ agreed by Defined2014.

@ti-chi-bot ti-chi-bot bot merged commit 6085651 into pingcap:master Oct 29, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enrich tests for foreign key with PREPARE and "Non-Transactional DML"
3 participants