-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add test for foreign key related to prepare and Non-Transactional DML #56366
tests: add test for foreign key related to prepare and Non-Transactional DML #56366
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #56366 +/- ##
=================================================
- Coverage 73.3876% 57.1456% -16.2421%
=================================================
Files 1620 1762 +142
Lines 447041 656880 +209839
=================================================
+ Hits 328073 375378 +47305
- Misses 98869 256920 +158051
- Partials 20099 24582 +4483
Flags with carried forward coverage won't be shown. Click here to find out more.
|
05fb7c2
to
a6a126b
Compare
Signed-off-by: Yang Keao <[email protected]>
a6a126b
to
e88925f
Compare
@YangKeao: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crazycs520, Defined2014 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #56365
Problem Summary:
We didn't have tests for the cooperation between foreign key and
PREPARE
or Non-Transactional DML. This PR adds these tests.What changed and how does it work?
Add two tests about the cooperation between foreign key and
PREPARE
or Non-Transactional DML.Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.