Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: enable fix control for enforced | tidb-test=pr/2404 #56414

Merged
merged 32 commits into from
Oct 22, 2024

Conversation

terry1purcell
Copy link
Contributor

@terry1purcell terry1purcell commented Sep 29, 2024

What problem does this PR solve?

Issue Number: close #46177

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/planner SIG: Planner labels Sep 29, 2024
Copy link

tiprow bot commented Sep 29, 2024

Hi @terry1purcell. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.2987%. Comparing base (255ea42) to head (4bae7a9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56414         +/-   ##
=================================================
- Coverage   73.3472%   56.2987%   -17.0486%     
=================================================
  Files          1635       1760        +125     
  Lines        452734     631632     +178898     
=================================================
+ Hits         332068     355601      +23533     
- Misses       100306     251996     +151690     
- Partials      20360      24035       +3675     
Flag Coverage Δ
integration 36.7264% <100.0000%> (?)
unit 72.4845% <100.0000%> (+0.0103%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.6981% <ø> (+6.6655%) ⬆️

@terry1purcell terry1purcell changed the title planner: remove fix control 46177 planner: remove fix control 46177 | tidb-test=pr/2404 Sep 30, 2024
@terry1purcell terry1purcell changed the title planner: remove fix control 46177 | tidb-test=pr/2404 planner: remove fix control for enforced | tidb-test=pr/2404 Oct 1, 2024
@terry1purcell terry1purcell changed the title planner: remove fix control for enforced | tidb-test=pr/2404 planner: remove fix control for enforced Oct 1, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 1, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 2, 2024
@terry1purcell terry1purcell changed the title planner: remove fix control for enforced planner: remove fix control for enforced | tidb-test=pr/2404 Oct 2, 2024
@terry1purcell terry1purcell changed the title planner: remove fix control for enforced | tidb-test=pr/2404 planner: enable fix control for enforced | tidb-test=pr/2404 Oct 7, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 8, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 16, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 22, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 22, 2024
Copy link

ti-chi-bot bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 22, 2024
Copy link

ti-chi-bot bot commented Oct 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-08 06:33:21.867751937 +0000 UTC m=+941357.287964944: ☑️ agreed by qw4990.
  • 2024-10-22 13:10:29.712269557 +0000 UTC m=+356630.409060182: ☑️ agreed by winoros.

@ti-chi-bot ti-chi-bot bot merged commit abf7e31 into pingcap:master Oct 22, 2024
21 checks passed
@terry1purcell terry1purcell deleted the enforced branch October 22, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexFullScan with higher cost is chosen to avoid sorting for window function
3 participants