Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: support dropping multiple foreign keys #56702

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

YangKeao
Copy link
Member

What problem does this PR solve?

Issue Number: close #28421

Problem Summary:

Previously, TiDB doesn't support dropping multiple foreign keys.

What changed and how does it work?

Add support for dropping multiple foreign keys.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Oct 17, 2024
@YangKeao YangKeao requested a review from crazycs520 October 17, 2024 05:42
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 17, 2024
@YangKeao YangKeao requested a review from bb7133 October 17, 2024 05:42
@YangKeao
Copy link
Member Author

/check-issue-triage-complete

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.0076%. Comparing base (900cd39) to head (8dffd49).
Report is 3 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56702         +/-   ##
=================================================
- Coverage   73.2928%   57.0076%   -16.2853%     
=================================================
  Files          1638       1789        +151     
  Lines        453733     640586     +186853     
=================================================
+ Hits         332554     365183      +32629     
- Misses       100816     250306     +149490     
- Partials      20363      25097       +4734     
Flag Coverage Δ
integration 39.3184% <100.0000%> (?)
unit 72.4901% <55.5555%> (-0.0150%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.1045% <ø> (+17.1311%) ⬆️

@YangKeao
Copy link
Member Author

/retest

@YangKeao YangKeao requested a review from lance6716 October 28, 2024 06:12
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 28, 2024
@YangKeao YangKeao requested review from tangenta and removed request for lance6716 October 28, 2024 06:31
Copy link

ti-chi-bot bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 28, 2024
Copy link

ti-chi-bot bot commented Oct 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-28 06:28:18.082088395 +0000 UTC m=+244810.921243942: ☑️ agreed by crazycs520.
  • 2024-10-28 06:35:09.150213119 +0000 UTC m=+245221.989368649: ☑️ agreed by tangenta.

@YangKeao
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit e6459b3 into pingcap:master Oct 28, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the operation of dropping multi-foreign-keys in one statement...
3 participants