-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: mitigate the issue that multiple owner might exist during force to be owner (#56963) #57052
ddl: mitigate the issue that multiple owner might exist during force to be owner (#56963) #57052
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.4 #57052 +/- ##
================================================
Coverage ? 56.7062%
================================================
Files ? 1748
Lines ? 621069
Branches ? 0
================================================
Hits ? 352185
Misses ? 245001
Partials ? 23883
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, Leavrth, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #56963
What problem does this PR solve?
Issue Number: close #56924, #56713
Problem Summary:
What changed and how does it work?
older versions which don't have the fix of #54689, when upgrade and forcing newer version node to be owner, multiple owner might exist at the same time, this pr tries to mitigate the issue, see code comments for more detail
also mitigate #57003 by sleep after force to be owner
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.