Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: mitigate the issue that multiple owner might exist during force to be owner (#56963) #57052

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #56963

What problem does this PR solve?

Issue Number: close #56924, #56713

Problem Summary:

What changed and how does it work?

older versions which don't have the fix of #54689, when upgrade and forcing newer version node to be owner, multiple owner might exist at the same time, this pr tries to mitigate the issue, see code comments for more detail

also mitigate #57003 by sleep after force to be owner

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • start a v7.5.0 cluster with 3 TiDBs, rolling upgrade to this pr, success
    • start a v8.1.1 cluster with 3 TiDBs, rolling upgrade to this pr, success
    • start a v7.5.0 cluster with 3 TiDBs, stop all TiDBs, then start them with this pr, success
      • Note: after this PR, we will aquire distributed lock before start domain, so in this case, the 2 non-owner node will not involve in schema version sync for upgrade DDL
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.4 labels Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 44.60784% with 113 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.4@3547038). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.4     #57052   +/-   ##
================================================
  Coverage               ?   56.7062%           
================================================
  Files                  ?       1748           
  Lines                  ?     621069           
  Branches               ?          0           
================================================
  Hits                   ?     352185           
  Misses                 ?     245001           
  Partials               ?      23883           
Flag Coverage Δ
integration 36.7763% <25.1231%> (?)
unit 72.5148% <41.1764%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.1719% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 1, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 1, 2024
Copy link

ti-chi-bot bot commented Nov 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-01 03:00:06.288381663 +0000 UTC m=+577919.127537206: ☑️ agreed by D3Hunter.
  • 2024-11-01 03:02:21.149792415 +0000 UTC m=+578053.988947960: ☑️ agreed by yudongusa.

@D3Hunter
Copy link
Contributor

D3Hunter commented Nov 1, 2024

/retest

Copy link

ti-chi-bot bot commented Nov 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, Leavrth, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 1, 2024
@ti-chi-bot ti-chi-bot bot merged commit 7e87622 into pingcap:release-8.4 Nov 1, 2024
35 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants