Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix list partition with non point range locates to a wrong partition #57072

Merged
merged 7 commits into from
Nov 11, 2024
Merged

planner: fix list partition with non point range locates to a wrong partition #57072

merged 7 commits into from
Nov 11, 2024

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Nov 1, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #57062

Problem Summary: Didn't process (KindNull, xxx] range well before #56725.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 1, 2024
@tiprow tiprow
Copy link

tiprow bot commented Nov 1, 2024

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014 Defined2014 added do-not-merge/needs-triage-completed needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Nov 1, 2024
@Defined2014 Defined2014 requested a review from winoros November 1, 2024 08:56
@codecov Codecov
Copy link

codecov bot commented Nov 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 57.0557%. Comparing base (5448f9f) to head (00dbd89).
Report is 62 commits behind head on master.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #57072         +/-   ##
=================================================
- Coverage   73.2123%   57.0557%   -16.1567%     
=================================================
  Files          1652       1794        +142     
  Lines        456050     653861     +197811     
=================================================
+ Hits         333885     373065      +39180     
- Misses       101648     256194     +154546     
- Partials      20517      24602       +4085
Flag Coverage Δ
integration 37.1975% <60.0000%> (?)
unit 72.6919% <60.0000%> (+0.2001%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 55.2602% <ø> (+2.3124%) ⬆️
parser ∅ <ø> (∅)
br 52.9287% <ø> (+6.9472%) ⬆️

@Defined2014 Defined2014 requested a review from mjonss November 1, 2024 09:12
@Defined2014
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Nov 1, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Nov 1, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014 Defined2014 changed the title planner: process fullRange correct for list partition prune planner: fix some bugs related with list partition table Nov 4, 2024
@Defined2014
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Nov 4, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014 Defined2014 changed the title planner: fix some bugs related with list partition table planner: deal fullRange correctly for list partition prune Nov 4, 2024
@Defined2014
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Nov 4, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Nov 5, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 5, 2024
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 5, 2024
@Defined2014 Defined2014 changed the title planner: deal fullRange correctly for list partition prune planner: revert #56725, use list column partition to achieve it Nov 5, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 5, 2024
@Defined2014 Defined2014 changed the title planner: revert #56725, use list column partition to achieve it planner: fix list partition with non point range locates to a wrong partition Nov 5, 2024
mjonss
mjonss reviewed Nov 6, 2024
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an explanation to why the pruning misses in the original test case / what the PR changes/fixes that?

pkg/planner/core/rule_partition_processor.go Show resolved Hide resolved
pkg/table/tables/partition.go Show resolved Hide resolved
@Defined2014
Copy link
Contributor Author

Defined2014 commented Nov 6, 2024 •
edited
Loading

Could you add an explanation to why the pruning misses in the original test case / what the PR changes/fixes that?

Didn't process (KindNull, xxx] range well before this PR.

@Defined2014 Defined2014 requested a review from tangenta November 6, 2024 08:22
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 6, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 8, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-06 08:48:43.691684571 +0000 UTC m=+1030836.530840109: ☑️ agreed by mjonss.
  • 2024-11-08 17:48:13.249641517 +0000 UTC m=+32855.440510511: ☑️ agreed by winoros.

@tiprow tiprow
Copy link

tiprow bot commented Nov 8, 2024

@Defined2014: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 00dbd89 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjonss, tangenta, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 11, 2024
@Defined2014
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Nov 11, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit d7fccb3 into pingcap:master Nov 11, 2024
22 of 23 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #57287.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 11, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Nov 11, 2024
@ti-chi-bot
planner: fix list partition with non point range locates to a wrong p…
d6d9b68 
…artition (#57072) (#57287)

close #57062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@winoros winoros winoros approved these changes

@mjonss mjonss mjonss approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong list partition prune for non point range
5 participants
@Defined2014 @ti-chi-bot @mjonss @winoros @tangenta