Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix the problem of not finding the referenced column in the virtual column #57084

Merged
merged 3 commits into from
Nov 11, 2024
Merged

planner: fix the problem of not finding the referenced column in the virtual column #57084

merged 3 commits into from
Nov 11, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Nov 3, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #57079

Problem Summary:

What changed and how does it work?

the problem happen at the executorBuilder.buildAnalyze.

ColumnInfos2ColumnsAndNames will find the virtual reference column by the column Infos. but when we enable analyze_skip_column_types, column Infos will lost some columns. so it cannot find its needed column.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/planner SIG: Planner and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Nov 3, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.4205%. Comparing base (05cec6d) to head (b85ab9c).
Report is 14 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #57084        +/-   ##
================================================
+ Coverage   72.9293%   73.4205%   +0.4911%     
================================================
  Files          1660       1660                
  Lines        458634     458685        +51     
================================================
+ Hits         334479     336769      +2290     
+ Misses       103627     101420      -2207     
+ Partials      20528      20496        -32
Flag Coverage Δ
integration 43.4300% <100.0000%> (?)
unit 72.2573% <100.0000%> (-0.0121%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 45.0544% <ø> (-0.0032%) ⬇️

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2024
@hawkingrei hawkingrei changed the title planner: fix analyze cannot be with json's virtual columns planner: fix the problem of not finding the referenced column in the virtual column Nov 6, 2024
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 8, 2024
@hawkingrei
update
be69532 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
fa70992 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
b85ab9c 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 11, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 11, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-11 07:14:04.535139102 +0000 UTC m=+254006.726008093: ☑️ agreed by AilinKid.
  • 2024-11-11 08:18:25.653293463 +0000 UTC m=+257867.844162458: ☑️ agreed by qw4990.

windtalker
windtalker approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, qw4990, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 3047328 into pingcap:master Nov 11, 2024
23 checks passed
@hawkingrei
Copy link
Member Author

/cherrypick release-8.5
/cherrypick release-8.1
/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-6.5: #57289.

In response to this:

/cherrypick release-8.5
/cherrypick release-8.1
/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 11, 2024
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#57084
e925241 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 11, 2024
Closed
13 tasks
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.1: #57290.

In response to this:

/cherrypick release-8.5
/cherrypick release-8.1
/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 11, 2024
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#57084
2f25ebc 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 11, 2024
Closed
13 tasks
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #57291.

In response to this:

/cherrypick release-8.5
/cherrypick release-8.1
/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 11, 2024
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#57084
0a881ca 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 11, 2024
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 11, 2024
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#57084
403dec2 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.1: #57292.

In response to this:

/cherrypick release-8.5
/cherrypick release-8.1
/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 11, 2024
Open
13 tasks
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.5: #57293.

In response to this:

/cherrypick release-8.5
/cherrypick release-8.1
/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 11, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Nov 12, 2024
@ti-chi-bot
planner: fix the problem of not finding the referenced column in the …
0a3aa2a 
…virtual column (#57084) (#57293)

close #57079
ti-chi-bot bot pushed a commit that referenced this pull request Dec 11, 2024
@ti-chi-bot
planner: fix the problem of not finding the referenced column in the …
2082f4b 
…virtual column (#57084) (#57291)

close #57079
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

@qw4990 qw4990 qw4990 approved these changes

@windtalker windtalker windtalker approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

analyze cannot be with json's virtual column
5 participants
@hawkingrei @ti-chi-bot @windtalker @qw4990 @AilinKid