-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: do not analyze non exist table anymore #57244
statistics: do not analyze non exist table anymore #57244
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57244 +/- ##
================================================
+ Coverage 72.8947% 74.0005% +1.1057%
================================================
Files 1667 1699 +32
Lines 460811 472502 +11691
================================================
+ Hits 335907 349654 +13747
+ Misses 104249 101584 -2665
- Partials 20655 21264 +609
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eaa6dc4
to
4c6941a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔢 Self-check (PR reviewed by myself and ready for feedback.)
// Analyze table with this version of statistics. | ||
TableStatsVer int | ||
// Weight is used to calculate the priority of the job. | ||
Weight float64 | ||
|
||
// Lazy initialized. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should put these fields into a substruct. But the PR is too big. I will do it later.
0653319
to
22f3c10
Compare
cf93429
to
a645cf5
Compare
/retest |
1 similar comment
/retest |
8fed1f1
to
6e2aefe
Compare
Signed-off-by: Rustin170506 <[email protected]>
6e2aefe
to
26196e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔢 Self-check (PR reviewed by myself and ready for feedback.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others LGTM.
TableSchema string | ||
TableName string | ||
Indexes []string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about unifying the naming, like DBName/SchemaName
, TableName
and IndexesNames
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated.
/retest |
1 similar comment
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: time-and-fate, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/test all |
/retest |
/test all |
@Rustin170506: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #57227
Problem Summary:
What changed and how does it work?
After #57222, we can handle most cases where tables have been dropped. However, there is still a chance that we might attempt to analyze a non-existent table or use incorrect information to perform the analysis.
In this PR, I check the schema and table information before performing the actual analysis. This helps minimize unnecessary analysis work.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.