*: make chunk.SwapColumn private

[windtalker]

What problem does this PR solve?

Issue Number: close #55885

Problem Summary:
The root cause is in Limit executor, it has an inline projection, but it use chunk.SwapColumn directly to do the projection, which will cause error if the Limit's output contains multiple column that point to same shallow column in input Chunk

What changed and how does it work?

This pr

1. make chunk.SwapColumn a private method, so it will not be used mistakenly
2. Rename ColumnEvaluator to ColumnSwapHelper and move it from expression package to chunk package
3. use ColumnSwapHelper to do the inline projection in Limit executor.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @windtalker. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 91.07143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.0260%. Comparing base (e16613d) to head (64d47a1).
Report is 31 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #57274        +/-   ##
================================================
+ Coverage   72.8878%   74.0260%   +1.1382%     
================================================
  Files          1667       1670         +3     
  Lines        460775     465559      +4784     
================================================
+ Hits         335849     344635      +8786     
+ Misses       104289     100379      -3910     
+ Partials      20637      20545        -92     

Flag	Coverage Δ
integration	43.7992% <91.0714%> (?)
unit	72.8204% <91.0714%> (+0.5448%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.7673% <ø> (ø)
parser	∅ <ø> (∅)
br	45.2858% <ø> (+0.2400%)	⬆️

[windtalker]

/test unit-test

[tiprow]

@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[windtalker]

/test unit-test

[tiprow]

@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [AilinKid,XuHuaiyu]
• pkg/expression/OWNERS [XuHuaiyu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-11-12 10:14:27.952772144 +0000 UTC m=+351230.143641140: ☑️ agreed by XuHuaiyu.
• 2024-11-13 03:55:11.885096084 +0000 UTC m=+414874.075965082: ☑️ agreed by AilinKid.

[AilinKid]

/ok-to-test

[windtalker]

/test fast_test_tiprow

[ti-chi-bot]

@windtalker: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test build
• /test check-dev
• /test check-dev2
• /test mysql-test
• /test pull-br-integration-test
• /test pull-integration-ddl-test
• /test pull-lightning-integration-test
• /test pull-mysql-client-test
• /test pull-unit-test-ddlv1
• /test unit-test

The following commands are available to trigger optional jobs:

• /test pingcap/tidb/canary_ghpr_unit_test
• /test pull-common-test
• /test pull-e2e-test
• /test pull-integration-common-test
• /test pull-integration-copr-test
• /test pull-integration-e2e-test
• /test pull-integration-jdbc-test
• /test pull-integration-mysql-test
• /test pull-integration-nodejs-test
• /test pull-integration-python-orm-test
• /test pull-sqllogic-test
• /test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

• pingcap/tidb/ghpr_build
• pingcap/tidb/ghpr_check
• pingcap/tidb/ghpr_check2
• pingcap/tidb/ghpr_mysql_test
• pingcap/tidb/ghpr_unit_test
• pingcap/tidb/pull_integration_ddl_test
• pingcap/tidb/pull_mysql_client_test

In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiprow]

@windtalker: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
fast_test_tiprow	64d47a1	link	true	/test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.5: #57368.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #57369.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.1: #57373.