Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: let exists subquery return signed int type #57277

Merged

Conversation

windtalker
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #56641

Problem Summary:
The root cause of #56641 is that exists subquery returns unsigned type in TiDB, and it is caused by that
in TiDB
expression.NewOne() and expression.NewZero() both returns unsigned integer type.
And in

if (row != nil && !v.Not) || (row == nil && v.Not) {
er.ctxStackAppend(expression.NewOne(), types.EmptyName)
} else {
er.ctxStackAppend(expression.NewZero(), types.EmptyName)
}

It use expression.NewOne() and expression.NewZero() as the result of the exists subquery.

The reason why expression.NewOne() and expression.NewZero() returns unsigned integer type is hard to tell now. The only thing I know is it is introduced in this pr: #21062 . Looks like it is not related to exists subquery.
It may have high regression risk to change the return type of expression.NewOne() and expression.NewZero(), so this pr adds two new function to return signed version on constant one and constant zero.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/planner SIG: Planner labels Nov 11, 2024
Copy link

tiprow bot commented Nov 11, 2024

Hi @windtalker. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.2274%. Comparing base (e16613d) to head (14b711a).
Report is 29 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57277        +/-   ##
================================================
+ Coverage   72.8878%   74.2274%   +1.3396%     
================================================
  Files          1667       1672         +5     
  Lines        460775     468033      +7258     
================================================
+ Hits         335849     347409     +11560     
+ Misses       104289     100173      -4116     
+ Partials      20637      20451       -186     
Flag Coverage Δ
integration 44.2342% <100.0000%> (?)
unit 73.1496% <100.0000%> (+0.8739%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 45.6727% <ø> (+0.6269%) ⬆️

Signed-off-by: xufei <[email protected]>
Signed-off-by: xufei <[email protected]>
@windtalker windtalker force-pushed the exists_subquery_return_signed_result branch from 0381d2a to 14b711a Compare November 11, 2024 07:51
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 12, 2024
Copy link

ti-chi-bot bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 13, 2024
Copy link

ti-chi-bot bot commented Nov 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-12 03:53:43.863470182 +0000 UTC m=+328386.054339174: ☑️ agreed by XuHuaiyu.
  • 2024-11-13 07:12:10.419637582 +0000 UTC m=+426692.610506571: ☑️ agreed by AilinKid.

Copy link

tiprow bot commented Nov 13, 2024

@windtalker: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 14b711a link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@windtalker
Copy link
Contributor Author

/test check-dev2

Copy link

tiprow bot commented Nov 13, 2024

@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 2d9f829 into pingcap:master Nov 13, 2024
22 of 23 checks passed
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 14, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #57365.

@windtalker windtalker deleted the exists_subquery_return_signed_result branch November 19, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiDB and MySQL behave differently when multiply EXISTS result and a signed integer
4 participants