-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: let exists subquery return signed int type #57277
planner: let exists subquery return signed int type #57277
Conversation
Hi @windtalker. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #57277 +/- ##
================================================
+ Coverage 72.8878% 74.2274% +1.3396%
================================================
Files 1667 1672 +5
Lines 460775 468033 +7258
================================================
+ Hits 335849 347409 +11560
+ Misses 104289 100173 -4116
+ Partials 20637 20451 -186
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: xufei <[email protected]>
Signed-off-by: xufei <[email protected]>
0381d2a
to
14b711a
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@windtalker: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/test check-dev2 |
@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #56641
Problem Summary:
The root cause of #56641 is that
exists
subquery returns unsigned type in TiDB, and it is caused by thatin TiDB
expression.NewOne()
andexpression.NewZero()
both returns unsigned integer type.And in
tidb/pkg/planner/core/expression_rewriter.go
Lines 1105 to 1109 in 56e7093
It use
expression.NewOne()
andexpression.NewZero()
as the result of the exists subquery.The reason why
expression.NewOne()
andexpression.NewZero()
returns unsigned integer type is hard to tell now. The only thing I know is it is introduced in this pr: #21062 . Looks like it is not related to exists subquery.It may have high regression risk to change the return type of
expression.NewOne()
andexpression.NewZero()
, so this pr adds two new function to return signed version on constant one and constant zero.What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.